search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Confirm Folder Deletion #4119

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by iangcarroll Friday Jul 12, 2013 at 23:13 GMT Originally opened as https://github.com/adobe/brackets/issues/4446

This would be extremely helpful so I don't delete my whole CSS folder, as I almost just did. phew

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Jul 15, 2013 at 18:51 GMT

Reviewed. We should prompt to confirm folder deletion but not file deletion (like Sublime does).

Also fyi@snapapps, the folder would not be gone forever. Like other editors, our delete commands just move to trash / recycle bin. (If anyone has ideas for making this more clear in the UI, let us know!)

core-ai-bot commented 3 years ago

Comment by WebsiteDeveloper Monday Jul 15, 2013 at 19:05 GMT

I think changing if from "Delete" to something like "Move to trash" would be more clear.

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Jul 15, 2013 at 19:26 GMT

@WebsiteDeveloper We'd need OS-specific strings in that case, but it seems reasonable to me...

core-ai-bot commented 3 years ago

Comment by sathyamoorthi Tuesday Jul 16, 2013 at 10:06 GMT

Just noticed. This is unfair. Anybody working on this?

core-ai-bot commented 3 years ago

Comment by swapnilgt Tuesday Jul 16, 2013 at 17:33 GMT

@peterflynn ,@sathyamoorthi : Hi. I am new to this project and github. I would like to work on this. Where to find the required code for modification? Already checked out the code and set up for dev.

core-ai-bot commented 3 years ago

Comment by discoursed Tuesday Jul 16, 2013 at 19:53 GMT

@swapnilgt@peterflynn

core-ai-bot commented 3 years ago

Comment by TomMalbran Tuesday Jul 16, 2013 at 20:58 GMT

@swapnilgt The file delete handler is on src/document/DocumentCommandsHandlers.js at line 1135.

core-ai-bot commented 3 years ago

Comment by swapnilgt Saturday Jul 20, 2013 at 10:39 GMT

@peterflynn any particular reason for not including the confirmation dialog for file deletion?

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Jul 22, 2013 at 18:40 GMT

@swapnilgt Other editors like Sublime don't confirm for single files. Because the files are just moved to the trash, it's an easily undoable operation. Modern OSes are moving away from confirmation dialogs too (albeit for folders also).