brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Potentially switching back to or supporting ACE editor #4142

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by ilsken Tuesday Jul 16, 2013 at 12:37 GMT Originally opened as https://github.com/adobe/brackets/issues/4472


ACE editor now uses a BSD license (licensing as I understand was the original reason for the switch). Moving back to ACE would have a few advantages

I've been considering starting a fork that replaces CM with ACE, just wanted to see if there'd be any interest. Personally I think it'd be a huge plus if developers can use the themes and features they are already familiar with in sublime/textmate/etc and have an editor that will be actively developed and maintained for a long time (CM is very active but I'd say there's a higher chance of ACE remaining in active and fast development just because of the bigger team and what it's developed for)

core-ai-bot commented 3 years ago

Comment by njx Tuesday Jul 16, 2013 at 17:21 GMT


@ilsken - thanks for your input. At this point I think it's highly unlikely we would switch to ACE. To address some of your notes:

Also, note that we would need to add inline editor support to ACE--again, that's not impossible to do (I had a prototype of it way back when we were first evaluating ACE vs. CM) but it's nontrivial work.

So, it's not clear to me that there are enough advantages to switching that it would justify the work. That said, if you're interested in forking and trying it out to see how it works, please feel free!

core-ai-bot commented 3 years ago

Comment by danyaPostfactum Saturday Aug 24, 2013 at 08:37 GMT


So, it's not clear to me that there are enough advantages to switching that it would justify the work

I am web-developer. I use Sublime Text for HTML/JS/CSS. When I found Brackets, I was impressed by feature list and user reviews. But when I tried to use it, I was disappointed by incontinence of editor. It's behaviour is too far from Sublime Text I used to use.

But I like open source and think that Brackets is great thing. I believe that Brackets needs Ace. It looks, feels and behaves almost like the Sublime Text.

So, I started to move Brackets to Ace. I am sure it is much easier to do than adding all editor features I (and many others) need to the CodeMirror.

Here is my repo: https://github.com/danyaPostfactum/brackets/tree/ace

The TODO list:

Any help is welcome!

@njx could you share your prototype of inline editor?

core-ai-bot commented 3 years ago

Comment by ilsken Saturday Aug 24, 2013 at 17:02 GMT


^ Very cool let me know if you need help with code completion, I've been working on a solution with ACE that uses esprima and escope for type-inferencing

core-ai-bot commented 3 years ago

Comment by danyaPostfactum Saturday Aug 24, 2013 at 17:08 GMT


Thanks@ilsken. In fact now I want to just get back all Bracket features first. So, I want to fix Bracket completion after moving to ACE (it's not hard). Then we can do better things.

core-ai-bot commented 3 years ago

Comment by danyaPostfactum Monday Aug 26, 2013 at 03:42 GMT


Current view: brackets

Added html syntax checking based on pure-js html5 w3c-compliant parser (attribute validation and nesting checks are in my todo)

core-ai-bot commented 3 years ago

Comment by danyaPostfactum Tuesday Aug 27, 2013 at 10:21 GMT


Added overrides of default theme by brackets styles: brackets