search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Fixes #4462 Update version of jslint to allow TODO comments #4147

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by csantanapr Tuesday Jul 16, 2013 at 17:01 GMT Originally opened as https://github.com/adobe/brackets/pull/4477

Updated jslint to latest version. Please review JSLint/main.js For some reason there is a problem with jasmine spy and that property object JSLINT.errors is undefined

Also with version of jslint the no-errors.js have errors (i.e empty block) added a very simple return x;

As mentioned in #4467 is good to create a submodule but some updates in bracket are need it to work with latest version of jslint and to be able to passs unit test.

csantanapr included the following code: https://github.com/adobe/brackets/pull/4477/commits

core-ai-bot commented 3 years ago

Comment by dangoor Wednesday Jul 17, 2013 at 19:37 GMT

hi@csantanapr, we decided to merge the commit that switches JSLint to a submodule and also talked about this pull request. We don't want to upgrade JSLint at this time, because we'll have to touch a bunch of files to do so.

We have it in mind to allow people to choose between JSHint and JSLint and for us to switch to JSHint ourselves. I think we would probably do that rather than fixing up all of our files for a new JSLint.

Thanks for your work on this, and do vote for that card on Trello which will actually provide more flexibility because you'd be able to use more recent JSLints or JSHint.

core-ai-bot commented 3 years ago

Comment by csantanapr Wednesday Jul 17, 2013 at 20:01 GMT

That's awesome to have the ability to select the linter engine

Would that feature work if I want to use ESLint?

Can you provide the Trello card link here to vote it up?

Now that I spent some time hacking brackets I'm using latest jslint and running out of master branch all the time :-) Good learning experience, I will be looking to some starter issues to help out

--Carlos

core-ai-bot commented 3 years ago

Comment by dangoor Wednesday Jul 17, 2013 at 20:27 GMT

Hi Carlos,

I think the general idea is that is should be possible to adapt basically any linter for use. Here's the card in Trello:

https://trello.com/c/SQhvGHri/498-3-jshint-support

Looking at your work on this feature, it looks like you've already gotten a pretty good handle on how Brackets works. If there's a feature you want to go after in core, feel free to bring it up on the googlegroup to be sure it doesn't conflict with work that's currently underway or just to chat about how the feature could work. Also, a lot of features start out life as extensions... You could probably build an extension that uses ESLint today.

Kevin

core-ai-bot commented 3 years ago

Comment by csantanapr Wednesday Jul 17, 2013 at 21:27 GMT

Thanks I will look into the docs on how to create extensions

I agree to keep the core small, simple, and the rest thru extensions.

I'm currently working with the Apache Cordova project and we jus took out all not critical plugins (i.e extensions) out of cordova core in the new version 3.0 with CLI support to manage them.

core-ai-bot commented 3 years ago

Comment by dangoor Thursday Jul 18, 2013 at 02:02 GMT

JSLint is actually an extension... it's just one we ship with Brackets by default.

There is definitely a tension in deciding which things to ship in core and which to leave as extensions.