search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Fix #4486 (No JSLint icon tooltip in some states) & small cleanups #4177

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Thursday Jul 18, 2013 at 22:57 GMT Originally opened as https://github.com/adobe/brackets/pull/4509

Fix bug #4486 (JSLint icon has no tooltip in some states) -- Don't use CSS to filter clicks on icon depending on state, since killing all mouse events also breaks tooltip. Use JS to filter instead.

Also clean up some comments in the JSLint plugin; remove confusing unused/unimplemented argument in StatusBar APIs; and tweak folder tree Refresh menu item for less ambiguity (ran by NJ earlier).

peterflynn included the following code: https://github.com/adobe/brackets/pull/4509/commits

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Aug 06, 2013 at 18:13 GMT

@peterflynn Initial review complete.

core-ai-bot commented 3 years ago

Comment by TomMalbran Tuesday Aug 06, 2013 at 19:56 GMT

I also found a bug in StatusBar.js#L118. It should say $indicator.addClass(style); instead of $indicator.addClass("style");.

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Aug 06, 2013 at 21:20 GMT

@jasonsanjose: Fixes pushed.

I also covered all of@TomMalbran's comments. The fix on StatusBar#118 should be safe because addClass("") is treated as a no-op by jQuery. (Though no one other than JSLint uses these APIs anyway, afaik).

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Aug 06, 2013 at 22:43 GMT

merging