search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [Core][Context menu]: To click Quick Edit and Quick Docs on context menu can not close the inline editor and Quick Docs. #4249

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by julieyuan Monday Jul 29, 2013 at 10:06 GMT Originally opened as https://github.com/adobe/brackets/issues/4594

Steps:

  1. Launch Brackets.
  2. Open a html file and put the curson before > .
  3. Right click to bring up context menu,Select Quick Edit.
  4. The inline editor is open, repeat step3.
  5. Open a css file and right click behind a property.
  6. Click Quick Docs on the context menu.
  7. The quick docs open, repeat step6.

Results: At step4 and step7, the inline editor and quick docs still keep open and can not collapse. But their shortcuts works well, pressing shortcuts at the second time can close them.

Expected: To press shortcuts and right click the menu should work the same. If the inline editor or Quick Docs pane opens, right click the menu should make them collapse.

ENV: MAC 10.8.3 and Win8 English OS Build: 0.28.0-8524

Snapshots: Please refer to snapshot for details:

screen shot 2013-07-29 at 2 41 26 am screen shot 2013-07-29 at 2 43 00 am

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Jul 29, 2013 at 17:35 GMT

This is currently working as intended. The behavior of the Quick Edit command depends on where focus is located. When keyboard focus is outside the widget (in the main / full-size editor), it does not close the inline editor -- it opens a new one. This is what you see in steps 4 & 7, because right-clicking moves the focus back to the main editor. Hitting the keyboard shortcut without right-clicking leaves the focus inside the inline editor. When focus is inside the editor,the Quick Edit command always closes it.

This can definitely be a bit confusing. I think in the past we've put off improving the Quick Edit toggle command until we do the full/official Quick Edit UX design, but that story might be defunct at this point. So maybe we should keep this open as a usability issue?

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Aug 05, 2013 at 18:34 GMT

Reviewed. Closing as 'move to backlog' since the user story linked above already covers this. (I've added a note to the card to clarify).