search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [Core][Search Result Panel]: The search result title is truncated if find a long string in project. #4256

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by julieyuan Tuesday Jul 30, 2013 at 07:59 GMT Originally opened as https://github.com/adobe/brackets/issues/4602

Steps:

  1. Launch Brackets.
  2. Select a long line string and to press shortcut Ctrl+Shift+F to find this string in project.
  3. Press Enter , then search result will appear on the bottom of Brackets.

Result: The search result title is truncated, and can not close the panel.

Expected: All strings display well.

ENV: MAC 10.8.3 and Win8.1 English OS Build: 0.28.0-8528

Snapshot: Please refer to snapshot for details: screen shot 2013-07-29 at 11 25 53 pm

core-ai-bot commented 3 years ago

Comment by jasonsanjose Monday Aug 05, 2013 at 18:36 GMT

Reviewed. Starter bug. Should be easy to fix the layout, use CSS to add ellipsis, add a tooltip, and confirm that the close X button is still visible and clickable.

core-ai-bot commented 3 years ago

Comment by zaggino Monday Aug 05, 2013 at 23:41 GMT

@jasonsanjose Not that easy, I tried - ellipsis is already there, layout of the search results probably has to be modified to solve this. I managed to get the close button always visible, but failed to trigger the CSS ellipsis on the text itself ...

core-ai-bot commented 3 years ago

Comment by zaggino Tuesday Aug 06, 2013 at 00:18 GMT

Finally managed to even trigger ellipsis with a few changes to the layout. image

core-ai-bot commented 3 years ago

Comment by TomMalbran Thursday Aug 22, 2013 at 22:27 GMT

FBNC@julieyuan

core-ai-bot commented 3 years ago

Comment by julieyuan Friday Aug 23, 2013 at 02:13 GMT

Thanks. Changes haven't been merged into latest build 0.30.0-8837 yet. Will check it in next build.

core-ai-bot commented 3 years ago

Comment by julieyuan Monday Aug 26, 2013 at 02:18 GMT

Not fixed in latest build 0.30.0-8873. Similar issue with #4870. Thanks for your efforts and sorry for it is still happening...Here is the snapshot for reference: capture dcran 2013-08-25 19 06 35

core-ai-bot commented 3 years ago

Comment by TomMalbran Monday Aug 26, 2013 at 02:40 GMT

Both issues where fixed using flex-box and they both work with the Sprint 29 shell but are broken in the new Sprint 30 shell. Something with the new version of chrome used in the latest shell broke this. Will see if I can fix it.

core-ai-bot commented 3 years ago

Comment by TomMalbran Friday Sep 06, 2013 at 22:50 GMT

FBNC again.@julieyuan can you test it please?

core-ai-bot commented 3 years ago

Comment by julieyuan Tuesday Sep 10, 2013 at 07:11 GMT

Fixed in build 0.31.0-9351. Great Job! Here is the snapshot: screen shot 2013-09-10 at 12 03 47 am