search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] fix failures in webplatform docs tests #4268

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by jasonsanjose Wednesday Jul 31, 2013 at 19:00 GMT Originally opened as https://github.com/adobe/brackets/pull/4616

Fixes breakage from #3429.@peterflynn can you review?

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/4616/commits

core-ai-bot commented 2 years ago

Comment by TomMalbran Wednesday Jul 31, 2013 at 21:05 GMT

I totally missed this. Wasn't expecting the changes in #3429 to break other tests, besides the ones it modified.

core-ai-bot commented 2 years ago

Comment by jasonsanjose Wednesday Jul 31, 2013 at 21:18 GMT

@TomMalbran no problem. You've got commit rights right? Care to merge?

core-ai-bot commented 2 years ago

Comment by peterflynn Wednesday Jul 31, 2013 at 21:34 GMT

Oops, sorry for missing this! I guess those tests didn't exist when I originally put up the pull request 4 months ago...

At least the assertions are doing what they were designed to, and finding erroneous code :-P

Looks right to me -- merging.