search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Update to Finnish localization #4382

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by ghost Saturday Aug 10, 2013 at 12:38 GMT Originally opened as https://github.com/adobe/brackets/pull/4741

Added new strings and two fixes to Finnish localization

ghost included the following code: https://github.com/adobe/brackets/pull/4741/commits

core-ai-bot commented 3 years ago

Comment by ghost Monday Aug 12, 2013 at 13:50 GMT

Added Getting Started project

core-ai-bot commented 3 years ago

Comment by jasonsanjose Friday Aug 23, 2013 at 21:03 GMT

Posted to the google group to get a review https://groups.google.com/d/msg/brackets-dev/FJEJQyyMDqk/0mrtdLABieAJ.

core-ai-bot commented 3 years ago

Comment by ghost Monday Aug 26, 2013 at 18:40 GMT

It's previewed on Google Group.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Friday Aug 30, 2013 at 18:30 GMT

@valtlait you'll also need to add a file src/nls/fi/urls.js so that we can pick up the getting started content. See the french directory for an example. I've gone ahead and filled in the appropriate Finnish URLs below.

define({
    // Relative to the samples folder
    "GETTING_STARTED"           : "fi/Aloitus",
    "ADOBE_THIRD_PARTY"         : "http://www.adobe.com/go/thirdparty_fi/",
    "WEB_PLATFORM_DOCS_LICENSE" : "http://creativecommons.org/licenses/by/3.0/deed.fi"
});
core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Sep 03, 2013 at 22:25 GMT

Looks good. There's one minor change to enable the getting started project. I'll do that separately. Thanks@valtlait.

core-ai-bot commented 3 years ago

Comment by lkcampbell Thursday Sep 05, 2013 at 14:28 GMT

@jasonsanjose, seems like this translation of the sample project is missing the screenshot directory and graphic.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Thursday Sep 05, 2013 at 16:11 GMT

Thanks. I'll file a bug.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Thursday Sep 05, 2013 at 16:14 GMT

Filed https://github.com/adobe/brackets/issues/5077.