[CLOSED] Find in Files Fixes (Issues #4751 and #4755)

[core-ai-bot]

Issue by TomMalbran Monday Aug 12, 2013 at 08:51 GMT Originally opened as https://github.com/adobe/brackets/pull/4752

---

• By reducing the matches by 1 when calculating the last page it fixes issue #4751 since we are actually starting counting from 0.
• Resets the current start to the maximum possible start when after deleting a file the current start ends higher than the number of matches, fixing issue #4755.
• Removed 2 unused strings in Find in Files.

---

TomMalbran included the following code: https://github.com/adobe/brackets/pull/4752/commits

[core-ai-bot]

Comment by JeffryBooher Tuesday Aug 20, 2013 at 01:31 GMT

---

@TomMalbran can you fix the travis build failure? It's complaining of a duplicate key. After that it's ready to go.

[core-ai-bot]

Comment by TomMalbran Tuesday Aug 20, 2013 at 02:27 GMT

---

@JeffryBooher There was an issue with the German strings having 2 duplicate strings when I posted the last commit, which was fixed after and is not coming from this PR. I'll do a no-op commit to make Travis run again.

[core-ai-bot]

Comment by TomMalbran Tuesday Aug 20, 2013 at 03:03 GMT

---

I found 2 uses of tabs instead of spaces, so I fixed that.

[core-ai-bot]

Comment by jasonsanjose Friday Aug 23, 2013 at 21:36 GMT

---

@TomMalbran can you take a look at the merge conflicts here? Thanks.

[core-ai-bot]

Comment by JeffryBooher Friday Aug 23, 2013 at 22:31 GMT

---

@TomMalbran because we need the translation kit to go to localization tonight, we needed to get the conflicts resolved so I resolved them in #4914. Closing this pull request in lieu of #4914.

[core-ai-bot]

Comment by TomMalbran Saturday Aug 24, 2013 at 01:31 GMT

---

Thanks for fixing the issue. I thought it was solved, since the original one didn't came from my PR (unless there was a new one that I didn't saw).