search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [Core][Live Preview]: If reload an html with unsaved css change, it will reload to page with original css setings. #4425

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by julieyuan Friday Aug 16, 2013 at 07:03 GMT Originally opened as https://github.com/adobe/brackets/issues/4786

Steps:

  1. Launch Brackets and open the default sample folder.
  2. Edit the CSS file without saving, for example, change property color or font size.
  3. Edit the index.html without saving, then Live Preview the index.html file.
  4. Click the reload icon on the top webpage which is before address bar.

Result: After reloading the webpage, changes in the html page stays, but changes in the CSS file are not be kept, it is set to the original CSS settings before step2.

Expected： After reloading the webpage, it should get the newest changes in html and css files.

Notes: This affects the use of Edge Web Fonts. If I live preview the html file , then want to change the font style with EWF, but I have to save the css file then I can see the fonts changing, otherwise I can not see the fonts changing.

ENV: MAC 10.8.3 and Win8 English OS Build: 0.30.0-8701

Snapshots: Please refer to snapshots for details: Before edit html and css files: capture dcran 2013-08-15 23 08 35

Change the css file without saving： capture dcran 2013-08-15 23 09 29

After reloading the webpage: capture dcran 2013-08-15 23 10 17

core-ai-bot commented 3 years ago

Comment by jasonsanjose Monday Aug 19, 2013 at 18:56 GMT

Assigned@jasonsanjose, medium priority. Could be related to #3970.

core-ai-bot commented 3 years ago

Comment by njx Tuesday Aug 20, 2013 at 00:50 GMT

Nominating for sprint 30 since it seems like a regression.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Aug 20, 2013 at 21:28 GMT

Fix in progress #4801

core-ai-bot commented 3 years ago

Comment by jasonsanjose Friday Aug 23, 2013 at 22:48 GMT

FBNC@julieyuan

core-ai-bot commented 3 years ago

Comment by julieyuan Monday Aug 26, 2013 at 03:08 GMT

Thanks! This issue is fixed in build 0.30.0-8873. Please refer to snapshot: capture dcran 2013-08-25 20 06 17

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Aug 26, 2013 at 04:14 GMT

@jasonsanjose Is it worth adding a unit test for this case? It sounds similar enough to the "should reapply in-memory css changes after saving changes" testcase in LiveDevelopement-test that I wonder if we could just quickly generalize that code to run both testcases...

core-ai-bot commented 3 years ago

Comment by jasonsanjose Monday Aug 26, 2013 at 22:43 GMT

@peterflynn working on it https://github.com/adobe/brackets/pull/4951.

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Aug 26, 2013 at 22:51 GMT

Sweet!