search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Fix shell tools for Linux #4446

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by IQAndreas Saturday Aug 17, 2013 at 18:37 GMT Originally opened as https://github.com/adobe/brackets/pull/4810

The shell scripts in the repo currently do not work at all for Linux systems. These changes allow the scripts to be run on Linux based systems, while still detecting whether the user is running OSX, and adjusts accordingly. The commits also include some general cleanup and fixing of existing code.

I split up the changes into several smaller commits, which both makes it clearer what each change does, and allows me to if needed "remove" any changes which are deemed "unrelated" to this pull request.

Tested and confirmed working on Ubuntu, but not any other Linux-based operating systems. As I don't have a MAC, I am unable to test if the shell scripts still work for OSX systems.

IQAndreas included the following code: https://github.com/adobe/brackets/pull/4810/commits

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Aug 20, 2013 at 23:55 GMT

Tested on Mac. Looks good. Just one minor comment. Thanks@IQAndreas!

core-ai-bot commented 3 years ago

Comment by IQAndreas Wednesday Aug 21, 2013 at 01:27 GMT

Good catch, the line has been fixed.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Wednesday Aug 21, 2013 at 01:30 GMT

Merging.

BTW, it looks like this was your first pull request for Brackets. Thanks for signing to CLA!