[CLOSED] Collect Named CSS Region Flows

brackets-archive / bracketsIssues

Archive of issues in brackets.

0 stars 0 forks source link

[CLOSED] Collect Named CSS Region Flows #4520

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by JeffryBooher Friday Aug 23, 2013 at 00:37 GMT Originally opened as https://github.com/adobe/brackets/pull/4890

Adds a function to extract all named css region flow names.

JeffryBooher included the following code: https://github.com/adobe/brackets/pull/4890/commits

core-ai-bot commented 3 years ago

Comment by JeffryBooher Friday Aug 23, 2013 at 04:38 GMT

@TomMalbran we only have to do@private when an object is exported with private methods. In this case we aren't exporting the functions so@private isn't required. The other "private" functions in this file also have JSDoc that doesn't start with@private.

core-ai-bot commented 3 years ago

Comment by TomMalbran Friday Aug 23, 2013 at 04:53 GMT

Ok. So I am not sure if we are suing@private always right then, the docs don't make it that clear either.

core-ai-bot commented 3 years ago

Comment by RaymondLim Friday Aug 23, 2013 at 06:45 GMT

Done with review. Only some minor nits.