search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Add ellipses to Replace All button label #4565

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Tuesday Aug 27, 2013 at 00:22 GMT Originally opened as https://github.com/adobe/brackets/pull/4953

...so it's not as scary to click. Without ellipses it looks like it will replace every occurrence immediately, which is how most "All" buttons in Find/Replace dialogs work.

@njx Seem reasonable?

@jasonsanjose I know this missed the string freeze date. Do you think it'd be ok to land anyway, even if the change is only visible in English for now? It seems like a worthwhile usability tweak. (Alternatively it'd be easy to manually update the existing Fr/Ja/De translations... but I'm guessing that breaks with ALF?)

peterflynn included the following code: https://github.com/adobe/brackets/pull/4953/commits

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Aug 27, 2013 at 01:53 GMT

If it's my call, it's no big deal for the translations to be out of sync just for an ellipsis. If it lands tonight it will be in no later than Wednesday night. We would likely accept a minor late string change like this. I'd rather not manually edit since we've gotten ALF screwed up in the past doing this. Merging.