search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Update notification is no longer modal #4662

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Thursday Sep 05, 2013 at 00:02 GMT Originally opened as https://github.com/adobe/brackets/issues/5062

  1. To mimic an installed build finding an update, make these changes in UpdateNotification:
    • Comment out the if (_buildNumber === 0 && !force) block (lines 275-278) -- so the block inside never runs
    • Comment out the if (force || allUpdates[0].buildNumber > _lastNotifiedBuildNumber) test (line 294) -- so the block inside always runs
    • or - alternative: just add force = true; at the top of checkForUpdate().
  2. Reload Brackets

Result: Update notification dialog appears but there's no dark gray "shield" behind it. Blinking cursor is still in the editor area, and if you type it will modify the editor. However, clicking/scrolling anywhere is still blocked, along with editor shortcuts like Ctrl+D or Ctrl+Z. Hitting Esc still closes the dialog, but hitting Enter does not.

Expected: Gray shield and all keystrokes go only to the dialog, same as if you show it via Help > Check for Updates.

I think the typing still working & the missing shield are both regressions due to PR #4714. Older builds may have shown a blinking cursor in the editor still, but I don't think typing would have actually done anything.

I think the problem is caused by the update popping up before the working set is restored, so the editor grabs focus from the dialog after the dialog is shown. (Not sure how it breaks the shield visuals, though -- especially since some sort of invisible shield is still clearly in place).

core-ai-bot commented 3 years ago

Comment by peterflynn Thursday Sep 05, 2013 at 00:04 GMT

Nominated for Sprint 31 since it was just introduced in 30. @TomMalbran would you want to take a look? Otherwise I think it's@njx who works on dialog/modality stuff the most.

core-ai-bot commented 3 years ago

Comment by RaymondLim Thursday Sep 05, 2013 at 06:52 GMT

@TomMalbran I verified that your changes for #4687 introduced this issue. If you removed the z-index code for nested dialogs, then typing won't insert any text into the main editor. But for dark gray "shield" behind the dialog to show up, you will also have to remove the following css changes.

.modal-backdrop {
    opacity: 0;
}
.modal-backdrop:last-child {
    /* Only show the last modal backdrop */
    opacity: 0.5;
}
core-ai-bot commented 3 years ago

Comment by peterflynn Thursday Sep 05, 2013 at 19:41 GMT

Oops, forgot to add to Trello bug card. Added now.

core-ai-bot commented 3 years ago

Comment by TomMalbran Thursday Sep 05, 2013 at 22:47 GMT

Yes, it was a dirty fix, and unfortunately, it can't be fixed in CSS, so we might need a JS solution.

We will also need to focus the dialog to fix the other issue. I haven't seen any issue with the z-index.

core-ai-bot commented 3 years ago

Comment by RaymondLim Wednesday Sep 18, 2013 at 05:44 GMT

FBNC to@peterflynn

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Sep 27, 2013 at 21:18 GMT

Confirmed fixed