search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Project tree breaks if filenames contain unusual chars #4680

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Thursday Sep 05, 2013 at 22:37 GMT Originally opened as https://github.com/adobe/brackets/issues/5080

  1. Right-click a folder > New File
  2. Type foo.(
  3. Press Enter

Result: Uncaught SyntaxError: Invalid regular expression: /.($/: Unterminated group in FileUtils._getFilenameWithoutExtension(), called via the jsTree sort callback in ProjectManager._renderTree().

If you repeat step 1, nothing happens -- the tree widget is basically non-functioning.

Expected: No error, since it's a valid filename.

core-ai-bot commented 3 years ago

Comment by peterflynn Thursday Sep 05, 2013 at 22:38 GMT

I think this will be fixed by #4846 assuming the code review advice about not using regexp is followed. Assigning to@JeffryBooher since he owns that code review.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Monday Sep 16, 2013 at 16:27 GMT

Indeed. This appears to be fixed with #5224

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Sep 27, 2013 at 21:14 GMT

Confirmed fixed now that it's merged