search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Intermittent failures in JS Code Hints #4698

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by njx Friday Sep 06, 2013 at 18:28 GMT Originally opened as https://github.com/adobe/brackets/issues/5099

When running the JS Code Hints unit tests (under Extensions) on the Mac, I often get a timeout failure in should format parameters with optional param following optional and required params, and also sometimes get a failure in should list declared variable and function names in outer scope. The failures are more likely to occur if you run all the Extension tests at once.

core-ai-bot commented 3 years ago

Comment by njx Friday Sep 06, 2013 at 18:30 GMT

To@RaymondLim for Sprint 31. Raymond was also seeing an intermittent failure in EditorCommandHandlers...not sure if it's related.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Monday Sep 09, 2013 at 21:53 GMT

FBNC@njx. I wasn't able to reproduce the failures before@RaymondLim's changes. I'm hoping you can confirm this fix.

core-ai-bot commented 3 years ago

Comment by redmunds Monday Sep 09, 2013 at 23:45 GMT

It doesn't seem to be causing any tests to fail, but I am seeing these exceptions (both Mac and Win) when running JS Code Hints unit tests:

Uncaught TypeError: Cannot call method 'getHints' of null main.js:330
getSessionHints main.js:330
(anonymous function) main.js:436
l jquery-2.0.1.min.js:4
c.fireWith jquery-2.0.1.min.js:4
(anonymous function) ScopeManager.js:1343
l jquery-2.0.1.min.js:4
c.fireWith jquery-2.0.1.min.js:4
handleTernCompletions ScopeManager.js:686
(anonymous function) ScopeManager.js:1056
core-ai-bot commented 3 years ago

Comment by njx Tuesday Sep 10, 2013 at 18:47 GMT

I'm seeing the same thing as@redmunds - no failures now, but an exception in one of the tests. (It's a little disturbing that Jasmine isn't reporting it--doesn't it usually catch and report exceptions?) The exception doesn't repro in the commit before the first one from the associated pull request, so this appears to be an injection from the fix.

Since@RaymondLim is out, would one of you guys be up for looking at this? I could take a look later but I want to focus on the remaining LiveHTML bug first.

core-ai-bot commented 3 years ago

Comment by njx Tuesday Sep 10, 2013 at 23:03 GMT

Removing FBNC tag

core-ai-bot commented 3 years ago

Comment by redmunds Tuesday Sep 10, 2013 at 23:09 GMT

@njx I submitted pull request https://github.com/adobe/brackets/pull/5158

core-ai-bot commented 3 years ago

Comment by njx Friday Sep 13, 2013 at 21:58 GMT

Confirmed, closing.