search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Unit tests hang after CodeMirror patches for issue #1787 #4766

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jasonsanjose Thursday Sep 12, 2013 at 17:38 GMT Originally opened as https://github.com/adobe/brackets/issues/5179

Spun off from #4564.

@RaymondLim reported that unit tests hang after doing a local merge for cursor positioning fixes in https://github.com/marijnh/CodeMirror/issues/1787#issuecomment-24231249

These fixes have not landed in Brackets yet, but we do integrate CodeMirror upstream/master at the beginning of every sprint. This will be an issue at the start of Sprint 32.

core-ai-bot commented 3 years ago

Comment by njx Friday Sep 20, 2013 at 23:45 GMT

The hang appears to be during createMockEditor(). Probably something to do with the fact that we create a fake editor holder.

core-ai-bot commented 3 years ago

Comment by njx Saturday Sep 21, 2013 at 00:01 GMT

Looks like the problem is just that our unit tests create mock editors inside an element that has no explicit width (and is absolutely positioned, so has no inherent width). That didn't cause a problem before, but it's understandable why Marijn's change would have broken this. It's arguably a CM bug, but since this isn't a realistic use case I think we can just change our unit tests to set an explicit width on the mock editor holder.

core-ai-bot commented 3 years ago

Comment by njx Monday Sep 23, 2013 at 20:20 GMT

Fixed this while merging the latest CM. Closing.