Open core-ai-bot opened 3 years ago
Comment by redmunds
Friday Sep 13, 2013 at 23:09 GMT
Done with review. Just a question about possibly deleting too much.
Comment by jasonsanjose
Friday Sep 13, 2013 at 23:22 GMT
Actually...hold on. I might have found an issue.
Comment by jasonsanjose
Friday Sep 13, 2013 at 23:26 GMT
@
redmunds false alarm. All tests recreate the temp folder as they need it via SpecRunner.copyPath
. We're good.
Fix intermittent failure (see 0.31.0.-9452 on windows) by replacing
fs-extra.remove()
in Node withbrackets.fs.unlink
viaSpecRunnerUtils.removeTempDirectory()
. Possible related issue from fs-extra rim-raf dependency https://github.com/isaacs/rimraf/issues/19.jasonsanjose included the following code: https://github.com/adobe/brackets/pull/5187/commits