[CLOSED] replace node fs-extra remove() with removeTempDirectory()

[core-ai-bot]

Issue by jasonsanjose Friday Sep 13, 2013 at 03:09 GMT Originally opened as https://github.com/adobe/brackets/pull/5187

---

Fix intermittent failure (see 0.31.0.-9452 on windows) by replacing fs-extra.remove() in Node with brackets.fs.unlink via SpecRunnerUtils.removeTempDirectory(). Possible related issue from fs-extra rim-raf dependency https://github.com/isaacs/rimraf/issues/19.

Error: Expected { errno : 53, code : 'ENOTEMPTY', path : 'C:\ws\Brackets-git\brackets\test\temp\extensions\user\basic-valid-extension' } to be null.
    at new jasmine.ExpectationResult (file:///C:/ws/Brackets-git/brackets/test/thirdparty/jasmine-core/jasmine.js:102:32)
    at null.toBeNull (file:///C:/ws/Brackets-git/brackets/test/thirdparty/jasmine-core/jasmine.js:1194:29)
    at NodeConnection.<anonymous> (file:///C:/ws/Brackets-git/brackets/test/spec/ExtensionInstallation-test.js:67:29)
    at NodeConnection.<anonymous> (file:///C:/ws/Brackets-git/brackets/src/thirdparty/jquery-2.0.1.min.js:4:26181)
    at l (file:///C:/ws/Brackets-git/brackets/src/thirdparty/jquery-2.0.1.min.js:4:24797)
    at Object.c.fireWith (file:///C:/ws/Brackets-git/brackets/src/thirdparty/jquery-2.0.1.min.js:4:25618)
    at NodeConnection._receive (file:///C:/ws/Brackets-git/brackets/src/utils/NodeConnection.js:422:34)

---

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/5187/commits

[core-ai-bot]

Comment by redmunds Friday Sep 13, 2013 at 23:09 GMT

---

Done with review. Just a question about possibly deleting too much.

[core-ai-bot]

Comment by jasonsanjose Friday Sep 13, 2013 at 23:22 GMT

---

Actually...hold on. I might have found an issue.

[core-ai-bot]

Comment by jasonsanjose Friday Sep 13, 2013 at 23:26 GMT

---

@redmunds false alarm. All tests recreate the temp folder as they need it via SpecRunner.copyPath. We're good.

[core-ai-bot]

Comment by redmunds Saturday Sep 14, 2013 at 00:17 GMT

---

Looks good. Merging.