brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [dark shell] Menu bar labels jump around vertically #4783

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Friday Sep 13, 2013 at 15:54 GMT Originally opened as https://github.com/adobe/brackets/issues/5197


I'm testing with the build Jeff sent out yesterday (WrathOfKhan9452)...

  1. Launch Brackets
  2. Mouse over some of the menu items
  3. Switch to another app
  4. Switch back

Result: 2 - menu item labels jump up a few px on mouseover. They remain higher on mouseout 4 - menu item labels have jumped back down, so you can repeat step 2

Here's a screenshot where I've moused over Debug & Help, and the remaining menu labels are in their original, lower position: dark shell2

core-ai-bot commented 3 years ago

Comment by njx Friday Sep 13, 2013 at 16:33 GMT


I'm not seeing that on my Win 7 machine...the labels are stable.

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Sep 13, 2013 at 16:49 GMT


Are you on the same build? I wonder what could be different then...

core-ai-bot commented 3 years ago

Comment by njx Friday Sep 13, 2013 at 16:54 GMT


Yup, downloaded from the build machine. 0.31.0-9452 / d90fd5f2f (though the SHA doesn't say anything about the shell I guess).

core-ai-bot commented 3 years ago

Comment by njx Friday Sep 13, 2013 at 16:57 GMT


Interestingly, I noticed another difference between your screenshot and the appearance on my machine: the "F" in File is farther to the left in your screenshot. (On mine, it starts near the right edge of the right bracket in the Brackets icon above, whereas on yours it's closer to the left bracket.) I wouldn't expect that to be different on different machines since it's all in the native code and isn't based on window width. Perhaps there's some difference in the OS appearance settings/theme that's different? (Are you running in a "classic" theme mode, maybe?)

core-ai-bot commented 3 years ago

Comment by njx Friday Sep 13, 2013 at 17:00 GMT


FWIW, I just switched into the "Windows Classic" theme, and that does indeed mess up the redraw of the menu items on mouseover, although in that case they move to the left on my machine (and you can see a little bit of the original position of the menu items peeking out). It doesn't sound like that's exactly your problem since the behavior is different, but that's probably something else we need to look at fixing.

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Sep 13, 2013 at 17:02 GMT


No, I'm running stock Windows 7. But note that the VM images of 7 usually have the more GPU-intensive look & feel options turned off, even if they're on by default for regular Windows 7 installs.

For example, if you open Notepad or something and drag it around, do you see a blurred version of the content behind it through the titlebar? If not, then your VM isn't running the default "Aero Glass" l&f. (And that might explain why you see flicker and I don't -- I think Aero Glass is double-buffered while the more simpler modes are not).

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Sep 13, 2013 at 17:05 GMT


i.e. if you go to Control Panel > Personalization, is the selected theme "Windows 7" (under "Aero Themes") or "Windows 7 Basic"?

core-ai-bot commented 3 years ago

Comment by njx Friday Sep 13, 2013 at 18:48 GMT


Yes, I'm using Aero Glass (it's listed as "custom theme", but I'm pretty sure it's based off the standard Windows 7 theme and it has the glass effects in the window chrome).

core-ai-bot commented 3 years ago

Comment by njx Friday Sep 13, 2013 at 18:49 GMT


I just switched to the Windows 7 theme and still don't see the menu issue.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Friday Sep 13, 2013 at 19:20 GMT


@peterflynn can you try today's 1108 build? This should be fixed now.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Friday Sep 13, 2013 at 19:26 GMT


@njx your issue should be fixed as well. @peterflynn It was actually fixed around 11:30pm PDT last night -- (I hope) but, to avoid confusion, please try today's latest build. I was computing where the menu items should be drawn and now ask the system and it is a much better experience. It fixed a couple of issues and one reported by@jasonsanjose on Windows 8 so I'm hoping that it fixes the issues on Windows 7 with Areo and Classic that both you and@njx were seeing.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Sunday Sep 15, 2013 at 04:44 GMT


Marking this as FBNC to@njx and@peterflynn

core-ai-bot commented 3 years ago

Comment by peterflynn Sunday Sep 15, 2013 at 11:05 GMT


Confirmed fixed in the "WrathOfKhan9477" build