brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Merge live-development branch into master #483

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by gruehle Friday Mar 23, 2012 at 00:39 GMT Originally opened as https://github.com/adobe/brackets/pull/485


Most of the live development functionality is commented out for now. The only parts that are hooked up are:

Commented out functionality includes:


gruehle included the following code: https://github.com/adobe/brackets/pull/485/commits

core-ai-bot commented 3 years ago

Comment by chrisbank Friday Mar 23, 2012 at 16:50 GMT


Reviewing

core-ai-bot commented 3 years ago

Comment by chrisbank Friday Mar 23, 2012 at 17:47 GMT


This looks good to merge as work in progress. All current unit tests are passing and the code is not doing any harm even if you click the "Go Live" button and it fails to connect although you get a ton of valid "Failed to load Resource" errors in the console.

I'll pull this when I finish the review in brackets-app

core-ai-bot commented 3 years ago

Comment by chrisbank Saturday Mar 24, 2012 at 00:47 GMT


This looks good