search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [Dark Shell] Window border appears on second monitor when maximized #4900

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by Icexist Tuesday Sep 24, 2013 at 17:30 GMT Originally opened as https://github.com/adobe/brackets/issues/5323

Using Windows 7 64-bit and Brackets 31 (sprint 31 experimental build 0.31.0-9569 (On branch sprint-31-hotfix,sprint-31-hotfix dd28c6a6e))

Using dual monitors, a narrow band of the window overlaps into the second window when Brackets is fully maximized.

Attached images display the problem from both the right and left screens, the arrows indicating the split between monitors. bracketserror2 bracketserror

How to reproduce:

  1. Open Brackets in a dual-monitor environment.
  2. Open fullscreen by either pressing the fullscreen button or dragging to the top of the screen in Windows 7
core-ai-bot commented 3 years ago

Comment by taylorthurlow Tuesday Sep 24, 2013 at 21:37 GMT

Can confirm. I'm running 3 monitors - the middle on has fullscreened Brackets loaded - each side of brackets has that white bar that extends onto each other monitor.

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Sep 25, 2013 at 02:28 GMT

Assigned@JeffryBooher. I can confirm too if I plug my Win 7 laptop into a second monitor.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Wednesday Sep 25, 2013 at 02:36 GMT

This is actually an FOL of all Windows that turn off theming except Microsoft Apps. So rather than have different code for XP and Windows Vista and Windows 8 -- we went with this. We should probably push this to PM since he would need to decide if he wants to invest in fixing this. It's only a problem when brackets has an active frame

core-ai-bot commented 3 years ago

Comment by JeffryBooher Wednesday Sep 25, 2013 at 02:37 GMT

Actually it happens with an inactive frame as well...

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Sep 25, 2013 at 03:13 GMT

@JeffryBooher I disagree about FOL... It doesn't happen with Office, Chrome, or iTunes -- all of which also have custom window chrome. That seems like good evidence that it's feasible to fix.

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Sep 25, 2013 at 03:14 GMT

Clarified title

core-ai-bot commented 3 years ago

Comment by JeffryBooher Wednesday Sep 25, 2013 at 21:48 GMT

@peterflynn I can send you a non themed app that's out of the box and it will do the same thing. This was something that I noticed early on and I posted to Microsoft's MSDN message board and the only response I got was that this is how it works on Windows with multiple monitors.

I'll ping@adrocknaphobia and see if he can get us some help from Microsoft. I spent a few days trying to solve it but came to the conclusion that it was just how it goes with this and that it wasn't worth spending a lot of time on. I have a barebones app that I wrote a back when I was trying to solve this that I can send to MS to see if anyone there has any suggestions...

core-ai-bot commented 3 years ago

Comment by taylorthurlow Wednesday Sep 25, 2013 at 22:06 GMT

@JeffryBooher It seems like more of a problem that it is worth to have the new 'dark' theme. Admittedly I like the dark more than the original windows styling but if it means having this white bar on my preview monitors then I'd go back to windows themed aero any day. Perhaps an option to enable/disable the dark mode?

core-ai-bot commented 3 years ago

Comment by njx Wednesday Sep 25, 2013 at 22:57 GMT

@peterflynn mentioned that Chrome doesn't exhibit this problem on Windows. Have we checked Chromium? If it doesn't have the problem, maybe we could look at the source to see what it's doing.

core-ai-bot commented 3 years ago

Comment by peterflynn Thursday Sep 26, 2013 at 17:10 GMT

@JeffryBooher Interesting behavior I noticed last night... perhaps a clue: other apps like Outlook & Chrome still seem to have a hit area that extends slightly onto the next monitor -- they just manage not to draw anything there. With Chrome, I actually get the horizontal-resize cursor over that area, even though the pixels there are from the app that legit belongs on that monitor. But with both apps, if the app doesn't have focus, clicking in that little strip will focus its window.

core-ai-bot commented 3 years ago

Comment by genericandy Friday Sep 27, 2013 at 16:06 GMT

I am seeing this behavior as well. If you cannot solve the problem, at least allow us to disable the dark theme so those of use who are working in a 2 monitor environment can work around the problem.

core-ai-bot commented 3 years ago

Comment by pthiess Thursday Oct 03, 2013 at 17:14 GMT

tagged for Sprint 33

core-ai-bot commented 3 years ago

Comment by HamsterCoder Friday Oct 04, 2013 at 15:17 GMT

Wow, I would have never noticed this about chrome =) Cheers for windows!

Confirm this bug on Win 7, x64, starting sprint 31.

core-ai-bot commented 3 years ago

Comment by mabasic Wednesday Oct 09, 2013 at 08:21 GMT

Same bug here. Windows 7 x64, Brackets sprint 31.

core-ai-bot commented 3 years ago

Comment by madcampos Friday Oct 11, 2013 at 21:57 GMT

i've got this bug on windows 8.1, brakets sprint 31.

as a posible solution on an app with custom chrome using node-webkit i overwride the default maximize and restore actions to just resize the window to the maximun available space. the code is the following:

var config,
    gui = require('nw.gui'),
    win = gui.Window.get(),
    unmaximizedWindow = [window.outerWidth, window.outerHeight, window.screenLeft, window.screenTop];

win.maximize = function(){
    unmaximizedWindow = [window.outerWidth, window.outerHeight, window.screenLeft, window.screenTop];
    window.resizeTo(screen.availWidth, screen.availHeight);
    window.moveTo(0, 0);
}

win.unmaximize = function(){
    window.resizeTo(unmaximizedWindow[0], unmaximizedWindow[1]);
    window.moveTo(unmaximizedWindow[2] - screen.availLeft, unmaximizedWindow[3] - screen.availTop);
}
core-ai-bot commented 3 years ago

Comment by JeffryBooher Wednesday Oct 23, 2013 at 17:57 GMT

Moving to sprint 34 as there won't be enough time left in 33 to fix; Moved this bug to the backlog to be reviewed and prioritized for sprint 34 (https://trello.com/c/pFO0rgs9)

core-ai-bot commented 3 years ago

Comment by StanFisher Wednesday Nov 27, 2013 at 15:53 GMT

I see this issue in Windows 7 in Sprint 34. The maximized window is also overlapping behind the taskbar a little.

core-ai-bot commented 3 years ago

Comment by vfalconi Wednesday Dec 04, 2013 at 21:13 GMT

I also see this issue in Win 7 with Sprint 34. I don't see the overlap with the taskbar (or maybe we're using different terms for the same thing...), but the icon in the top left of the window seems to be cut off slightly by the menu bar.

Not maximized: not-maximized

Maximized: maximized

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Dec 04, 2013 at 21:17 GMT

@vfalconi That sounds like a different issue. Can you file that as a new bug? (With the same two screenshots attached)

core-ai-bot commented 3 years ago

Comment by VizuaaLOG Monday Dec 16, 2013 at 20:20 GMT

Just wondering if there is a fix for this as I regularly use two monitors and it is quite distracting when changing windows and seeing the white bar appearing or disappearing.

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Dec 17, 2013 at 01:43 GMT

@VizuaaLOG It's marked 'fix in progress' and set to the Sprint 36 milestone, so it should land in the first release in January.

This bug has fallen out of several sprints in the past, so those indicators aren't as reliable as they would be for most bugs... but in this case I believe@JeffryBooher has said he's very close to a finished fix now -- he's been working on it for quite some time already.

core-ai-bot commented 3 years ago

Comment by sirodoht Tuesday Dec 17, 2013 at 21:58 GMT

Win 8.1, x64, sprint 34 When Brackets is maximized it extends some pixels below the taskbar. Probably the same bug? brackets-issue-5323

core-ai-bot commented 3 years ago

Comment by VizuaaLOG Tuesday Dec 17, 2013 at 22:43 GMT

@peterflynn Oh ok will look forward to that release :)

core-ai-bot commented 3 years ago

Comment by Studio384 Tuesday Dec 17, 2013 at 22:56 GMT

I can confirm the issue sirodoht mentioned here.

core-ai-bot commented 3 years ago

Comment by mikkotikkanen Wednesday Dec 18, 2013 at 19:04 GMT

Same here. brackets-overlap-taskbar

core-ai-bot commented 3 years ago

Comment by VizuaaLOG Wednesday Dec 18, 2013 at 22:49 GMT

@mikkotikkanen Kind of off topic but what theme is that?

core-ai-bot commented 3 years ago

Comment by mikkotikkanen Wednesday Dec 18, 2013 at 22:52 GMT

Ambiance from Themes for Brackets -extension

core-ai-bot commented 3 years ago

Comment by VizuaaLOG Thursday Dec 19, 2013 at 17:33 GMT

@mikkotikkanen Thanks :)

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Dec 20, 2013 at 17:45 GMT

@JeffryBooher I'm going to bump this up to a High so we really focus extra attention on getting the fix landed in Sprint 36. At this point this is basically our most-duped bug ever, so it is very high-profile. Lmk if you disagree with the priority.

core-ai-bot commented 3 years ago

Comment by peterflynn Thursday Jan 09, 2014 at 22:50 GMT

Note: I've archived the user story https://trello.com/c/pFO0rgs9/1044-window-border-appears-on-second-monitor-when-maximized-windows-only which was basically just a dupe of this bug. We never pulled it into the sprints where this work was ongoing, and now the fix is about to land... so there didn't seem much point in keeping the card around anymore.