search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Cubic Bezier Editor sometimes doesn't work after using out of range values #5107

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by ingorichter Friday Oct 18, 2013 at 18:25 GMT Originally opened as https://github.com/adobe/brackets/issues/5570

Create a new css document and paste this line

#div6 {transition-timing-function: cubic-bezier(0, 0, 0, 0); } Now press Cmd+E and open the Cubic Bezier Inline Editor. This works as expected.

Now change the line to #div6 {transition-timing-function: cubic-bezier(0, 0, 3, 3); } Now press Cmd+E. The Inline Editor doesn't show up. The cubic-bezier(0, 0, 3, 3) expression gets selected.

Now change the line back to #div6 {transition-timing-function: cubic-bezier(0, 0, 0, 0); } Now press Cmd+E. In my case, the Inline Editor doesn't always show up. The cubic-bezier(0, 0, 0, 0) expression gets selected again or the editor opens.

From the console log: Uncaught Wrong coordinate at 2(3) BezierCurveEditor.js:73 CubicBezier BezierCurveEditor.js:73 BezierCurveEditor._updateCanvas BezierCurveEditor.js:653 BezierCurveEditor BezierCurveEditor.js:528 InlineBezierCurveEditor.load InlineBezierCurveEditor.js:187 inlineBezierCurveEditorProvider main.js:141 _openInlineWidget EditorManager.js:169 _toggleInlineWidget EditorManager.js:738 (anonymous function) EditorManager.js:799 Command.execute CommandManager.js:90 execute CommandManager.js:275 executeCommand ShellAPI.js:64

core-ai-bot commented 3 years ago

Comment by redmunds Saturday Oct 19, 2013 at 01:02 GMT

Great catch! I have this fixed locally in my unit test branch.

core-ai-bot commented 3 years ago

Comment by redmunds Tuesday Oct 22, 2013 at 23:29 GMT

@ingorichter I'm not sure if the unit tests will make it into this Sprint, so I submitted pull request https://github.com/adobe/brackets/pull/5636 for this fix.

core-ai-bot commented 3 years ago

Comment by redmunds Wednesday Oct 23, 2013 at 20:24 GMT

FBNC back to@ingorichter

core-ai-bot commented 3 years ago

Comment by ingorichter Monday Oct 28, 2013 at 17:17 GMT

@redmunds the exception doesn't show up anymore. Fixed and closed!