[CLOSED] Enable rule switching and resize logic between rule list and displayed CSS rule

brackets-archive / bracketsIssues

Archive of issues in brackets.

0 stars 0 forks source link

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by tvoliter Friday Mar 30, 2012 at 23:46 GMT Originally opened as https://github.com/adobe/brackets/pull/515

renamed InlineEditor to InlineWidget
CSSInlineEditor.setSelectedRule() now removes the current rule editor and replaces it with a new one
added CSSInlineEditor.sizeInlineWidgetToContents to resize widget contents based on rule list and the displayed rule

tvoliter included the following code: https://github.com/adobe/brackets/pull/515/commits

core-ai-bot commented 3 years ago

Comment by jasonsanjose Friday Mar 30, 2012 at 23:46 GMT

reviewing

core-ai-bot commented 3 years ago

Comment by jasonsanjose Saturday Mar 31, 2012 at 00:28 GMT

Initial review complete

core-ai-bot commented 3 years ago

Comment by tvoliter Monday Apr 02, 2012 at 05:52 GMT

Jason, I've addressed all your comments, but haven't gotten to Peter's regarding the shortcuts

core-ai-bot commented 3 years ago

Comment by jasonsanjose Monday Apr 02, 2012 at 06:10 GMT

Thanks for the quick fixes. One last issue with the rule list scrolling in CSSInlineEditor lines 93 and 97.