search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [Review Only] Unit Tests for InlineTimingFunctionEditor cubic bezier #5206

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by redmunds Thursday Oct 24, 2013 at 22:53 GMT Originally opened as https://github.com/adobe/brackets/pull/5678

I marked as [Review Only] because I need to squash commits before this is merged.

cc@bchintx

redmunds included the following code: https://github.com/adobe/brackets/pull/5678/commits

core-ai-bot commented 3 years ago

Comment by bchintx Thursday Oct 24, 2013 at 23:39 GMT

@redmunds Done with initial review. Just the two questions/comments noted. I can't think of any other scenarios to test. In fact, I didn't know that you could even test as many behaviors as you did in your tests. Nice job.

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Oct 24, 2013 at 23:57 GMT

I realized last test wasn't checking things correctly, so I fixed it. Please take another look at that one.

core-ai-bot commented 3 years ago

Comment by bchintx Friday Oct 25, 2013 at 01:29 GMT

No concerns with the last commit to add the callback. Done with next review.

core-ai-bot commented 3 years ago

Comment by bchintx Friday Oct 25, 2013 at 16:22 GMT

Sounds fine. I'm good with moving forward then to create a new, squashed pull request. Done with review.

core-ai-bot commented 3 years ago

Comment by bchintx Friday Oct 25, 2013 at 16:51 GMT

Closing this pull request in lieu of merging the above-referenced, squashed on.