search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [Core][Preview image]: It should pop up Error opening file dialog if click the image which is deleted from OS. #5264

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by julieyuan Tuesday Oct 29, 2013 at 07:16 GMT Originally opened as https://github.com/adobe/brackets/issues/5742

Updating description because the scenario overlaps with #5978. Steps:

  1. Launch Brackets and open the default sample folder.
  2. open index.html
  3. switch to finder/explorer and delete screenshots/quick-edit.png from project
  4. Back to Brackets and click this image quick-edit.png. Expected Result: At step 4, it doesn't pop up Error opening file dialog, but empty ImageViewer is displayed

ENV: MAC 10.8 and Win8.1 English OS

----------- original description: Steps:

  1. Launch Brackets and open the default sample folder.
  2. Right click on the image quick-edit.png and select "Show in OS".
  3. Delete this image from OS.
  4. Back to Brackets and click this image quick-edit.png.
  5. Try to rename or delete this image from Brackets by right clicking menu.

Results: At step 4, it doesn't pop up Error opening file dialog. At step5, it will pop up Error renaming file and Error deleting file dialog. (correct behavior)

Expected: At step4, it should pop up Error opening file dialog to update the change outside of Brackets.

ENV: MAC 10.8 and Win8.1 English OS Build: 0.33.0-10155

Snapshots: Please refer to snapshot for details: capture decran 2013-10-29 a 12 13 03 am

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Oct 29, 2013 at 07:56 GMT

@julieyuan We don't update the tree when a text file is deleted externally only. It sounds like the only bug specific to Image Preview is that we don't show an error popup in step 4 when you click the deleted file?

core-ai-bot commented 3 years ago

Comment by julieyuan Tuesday Oct 29, 2013 at 08:11 GMT

@peterflynn yes, you are right. Sorry for the confusion. Correct the title to "It should pop up Error opening file dialog if click the image which is deleted from OS" (original is "The project tree is not update if the image is deleted from OS.")

core-ai-bot commented 3 years ago

Comment by RaymondLim Tuesday Oct 29, 2013 at 18:24 GMT

Nominating for sprint 34.

core-ai-bot commented 3 years ago

Comment by njx Thursday Oct 31, 2013 at 22:42 GMT

Assigning to@couzteau

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Nov 01, 2013 at 20:07 GMT

I bet we could fix this with a simple file.exists() check...

core-ai-bot commented 3 years ago

Comment by couzteau Friday Nov 08, 2013 at 00:55 GMT

Pull request with fix will follow as soon as the file system branch has been merged: https://github.com/adobe/brackets/pull/5797

The fix depends on file.exists API provided by new file system

core-ai-bot commented 3 years ago

Comment by RaymondLim Wednesday Nov 13, 2013 at 22:29 GMT

FBNC to@julieyuan

core-ai-bot commented 3 years ago

Comment by julieyuan Thursday Nov 14, 2013 at 02:16 GMT

Thanks you all. The fix has not merged into latest build (0.34.0-10678, master fd686b4f5) yet. Will verify it with next build.

core-ai-bot commented 3 years ago

Comment by julieyuan Friday Nov 15, 2013 at 01:36 GMT

This issue is fixed with build 0.34.0-10711. Good job ! So closing it. Here is the snapshot for reference: screen shot 2013-11-14 at 5 33 56 pm

core-ai-bot commented 3 years ago

Comment by RaymondLim Friday Nov 15, 2013 at 05:08 GMT

Reopen it since fixing #5986 brings this one back. Nominating for sprint 35.

core-ai-bot commented 3 years ago

Comment by couzteau Friday Nov 15, 2013 at 05:12 GMT

Updated description, fix can be validated once PR #6002 is merged, we also do need to fix #5978.

core-ai-bot commented 3 years ago

Comment by RaymondLim Friday Nov 15, 2013 at 05:17 GMT

@couzteau Until we fix #5978, we cannot claim that this is fixed with #6002.

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Nov 15, 2013 at 07:37 GMT

I think we can call this one fixed (and close it once verified) since the remaining part is tracked by #5978...

core-ai-bot commented 3 years ago

Comment by peterflynn Thursday Nov 21, 2013 at 22:08 GMT

Closing since #5978 is tracking the one remaining incorrect behavior. I'll add a note there to verify this bug's original end-to-end steps once that final piece is fixed.