brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Brackets freezes when try to open (minified) PhoneJS file #5286

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by FezVrasta Wednesday Oct 30, 2013 at 18:22 GMT Originally opened as https://github.com/adobe/brackets/issues/5769


I'm using the Spint 32 of Brackets on Windows 8 Pro 64 bit. My PC has 8GB of RAM and an AMD 8-core 3.2 GHz processor.

What causes the problem?

Open a minified .js file of 9 rows and about 250kB of code.

What happens?

The editor freezes and I have to kill it using the task manager.

What is expected to happens?

The file is opened correctly and I can edit and read it.

Additional informations: If I try to open the beautified version of the same file the editor is very slow and freezes on scroll or during actions like "Search" or "Save". If I open the same files with Notepad++ everything is very fast.

The file: http://pastebin.com/Uq3pkH7B

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Oct 30, 2013 at 18:24 GMT


Cleaning up title (was "[Bug] Brackets freezes when try to open minified files"). According to filer on IRC, if you open the unminified version, Brackets works ok for a few moments and then freezes anyway. Other unminified files of a similar size (e.g. jQuery) work fine, so I'm wondering if this may be another pathological Tern case...

core-ai-bot commented 3 years ago

Comment by FezVrasta Wednesday Oct 30, 2013 at 18:31 GMT


jQuery 2.0.3 makes my Brackets freezes as well link

But the code is shown in the editor before it freezes, instead with PhoneJS the code is neither shown.

After some minutes the editor works with jQuery, but it was frooze for few minutes.

core-ai-bot commented 3 years ago

Comment by FezVrasta Wednesday Oct 30, 2013 at 18:54 GMT


Update

jQuery Open jquery-2.0.3 not minified doesn't cause problems, everything works well. Open jquery-2.0.3 minified makes Brackets laggy on scroll an search Open the beautified version of jquery-2.0.3 doesn't cause problems, just like the not minified version.

PhoneJS The minified version of dx.phonejs.js freezes Brackets, the code is not shown at all and I can't neither close Brackets using the shortcut. The beautified version of dx.phonejs.js makes the editor lag badly.

I've noticed that if I open the beautified version of PhoneJS from a file saved in my PC, it lags badly. Instead if I copy the code from Notepad++ and paste it in Brackets, it works well.

If I try to copy and paste the minified version, it takes a while to load but after that the scroll works well, but if I try to edit the code it takes ages to apply the edits (adding a character, deleting one).

I hope it can help.

PS: Even Knockout minified has the same lag problems, similar to the the minified version of jQuery

core-ai-bot commented 3 years ago

Comment by njx Monday Nov 04, 2013 at 19:48 GMT


To@dangoor to figure out what's going on in these various cases, since it's possible it might be related to Tern. Marking medium priority for now until we know more.

core-ai-bot commented 3 years ago

Comment by FezVrasta Monday Nov 04, 2013 at 20:32 GMT


I've not Ternific installed (if is useful to find the problem)

core-ai-bot commented 3 years ago

Comment by njx Saturday Nov 16, 2013 at 01:02 GMT


Nominating for sprint 35

core-ai-bot commented 3 years ago

Comment by FezVrasta Monday Nov 18, 2013 at 11:36 GMT


Just got an idea. The difference of lag between files opened from hard disk and test pasted in a new file could be related to the function of Brackets that checks for changes in the original file?

core-ai-bot commented 3 years ago

Comment by dangoor Wednesday Dec 04, 2013 at 15:31 GMT


@FezVrasta can you try it again with the latest code in master? (Make sure you've got an updated brackets-shell, if you do, also don't forget to update submodules). There are two fixes that have gone in that could have an impact here:

I added a "phone.js" file to my Brackets repo and pasted in the minified contents. It was slow to paste/initialize, but once it did things behaved reasonably. I also tried beautifying the file and loading it from disk... that behaved well and code hints worked fine as well.

core-ai-bot commented 3 years ago

Comment by njx Friday Dec 06, 2013 at 18:12 GMT


Moved to sprint 36 since we're just waiting for verification.

core-ai-bot commented 3 years ago

Comment by FezVrasta Tuesday Dec 10, 2013 at 08:03 GMT


Sorry for the delay, will try when I'm on the home pc.

core-ai-bot commented 3 years ago

Comment by dangoor Thursday Jan 02, 2014 at 18:11 GMT


@FezVrasta You can test this with a Sprint 35 build now and see if things have gotten better for you