Open core-ai-bot opened 3 years ago
Comment by MarcelGerber Thursday Oct 31, 2013 at 16:13 GMT
Little hint:
You don't have to create a new Pull Request for every change you made, you can just add commits to the branch the PR uses (in this case patch-4
).
Comment by FatihEsen Thursday Oct 31, 2013 at 17:48 GMT
Sorry
2013/10/31 Marcel Gerber notifications@github.com
Little hint: You don't have to create a new Pull Request for every change you made, you can just add commits to the branch the PR uses (in this case patch-4).
— Reply to this email directly or view it on GitHubhttps://github.com/adobe/brackets/pull/5788#issuecomment-27499962 .
Comment by jasonsanjose Friday Nov 01, 2013 at 18:35 GMT
@
FatihEsen can you confirm that this pull request has all the changes from each of your prior pull requests? If so, I'd like to close them: #5720, #5724, #5734, #5764, #5786.
If you need help with using git, please ask! :)
Next time you need to update your translation, you can switch to this branch, make the changes there, commit them, then push them back to github:
brackets$ git checkout patch-4 # switch to this branch associated with this pull request
brackets$ # edit src/nls/tr/strings.js
brackets$ git add src/nls/tr/strings.js # stage the file
brackets$ git commit -m "update turkish translation" # commit the file
brackets$ git push origin patch-4 # push your local branch to the remote github repo to automatically update this pull request
Comment by jasonsanjose Friday Nov 01, 2013 at 18:40 GMT
@
Sly777 since you worked on the original translation, are you available to review@
FatihEsen's changes?
In addition to the new strings, I see many already translated strings were changed.
Comment by jasonsanjose Friday Nov 01, 2013 at 18:45 GMT
@
FatihEsen if for some reason you're having issues with git, you could also edit the file directly from GitHub. Here's the direct link to the file on your branch https://github.com/FatihEsen/brackets/blob/patch-4/src/nls/tr/strings.js. Click on the Edit
button to edit the file in-browser.
Comment by FatihEsen Friday Nov 01, 2013 at 19:56 GMT
yes i confirm it,
usually your own copy of the work, sometimes sending pull request. I wonder if the original copy is considered when.
(i dont speak english)
Ben aslında kendi repositorymde çalışıyorum. bazen çekme isteği gönderiyorum. acaba ne zaman benim çalışama asıl projeye dahil olur merak ediyorum.
Issue by FatihEsen Thursday Oct 31, 2013 at 15:56 GMT Originally opened as https://github.com/adobe/brackets/pull/5788
FatihEsen included the following code: https://github.com/adobe/brackets/pull/5788/commits