search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Implement steps() timing function editor #5312

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by redmunds Thursday Oct 31, 2013 at 23:37 GMT Originally opened as https://github.com/adobe/brackets/pull/5799

  1. I added support for steps() timing function.
  2. I refactored the existing inline timing function code for cubic-bezier().
  3. I developed this using TDD, so this includes Unit Tests.

Support for:

Keyboard Events

Mouse support

Issues?

redmunds included the following code: https://github.com/adobe/brackets/pull/5799/commits

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Oct 31, 2013 at 23:39 GMT

@larz0 Here is the steps() function code.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Thursday Nov 21, 2013 at 18:04 GMT

Nominating for Sprint 35

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Nov 21, 2013 at 21:12 GMT

@larz0 This pull request was nominated for Sprint 35. Can you take a look and respond with what you think needs to be done to this feature for it to get into master? Then we can figure out if we can get it done this sprint.

core-ai-bot commented 3 years ago

Comment by larz0 Thursday Nov 21, 2013 at 21:20 GMT

@redmunds ok I'll take a look this afternoon.

core-ai-bot commented 3 years ago

Comment by redmunds Wednesday Dec 04, 2013 at 00:08 GMT

@larz0 I added some info text for both the cubic-bezier and steps editors. Let me know what you think.

It's going to be a fair amount of work to display error messages (need separate test and string for every possible error), so I want to make sure this is on the right track before proceeding.

If it's OK, then feel free to tweak position, styles, text, etc.

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Jan 02, 2014 at 20:21 GMT

@larz0 I thought you asked me to add symbols for arrow keys to the info text (but I can't seem to find your comment), so I added those. I looked for unicode symbols for mouse click and drag operations, but couldn't find anything -- I suppose we could use images.

Let me know what else you think needs to be done to merge this into master. In the spirit of agile, maybe we should merge what we have and listen for feedback?

core-ai-bot commented 3 years ago

Comment by larz0 Thursday Jan 02, 2014 at 21:08 GMT

I'd like to make it more like the screenshot below. What do you think? I can push the changes to this PR.

screen shot 2014-01-02 at 1 06 33 pm

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Jan 02, 2014 at 21:14 GMT

I like that! Is that format used anywhere else in Brackets so I could re-use the boxes and background-color?

I also added info text to cubic-bezier() editor, so that's why I was asking about mouse click and drag. Suggestions?

core-ai-bot commented 3 years ago

Comment by larz0 Thursday Jan 02, 2014 at 21:18 GMT

Awesome. I'll make those changes in cubic-bezier as well. I'm going to remove "Bezier curve endpoints can be dragged with mouse." because it's pretty clear that they can be dragged as they look like typical bezier curve handles.

core-ai-bot commented 3 years ago

Comment by larz0 Thursday Jan 02, 2014 at 21:43 GMT

@redmunds I've made the changes, might want to take a look just in case.

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Jan 02, 2014 at 22:18 GMT

Looks awesome! Let me know when you're happy with XD side, and I'll get a dev to give this a code review.

core-ai-bot commented 3 years ago

Comment by larz0 Thursday Jan 02, 2014 at 22:22 GMT

@redmunds I'm happy with XD side. Let's try and merge this :)

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Jan 02, 2014 at 22:34 GMT

XD review is complete. Ready for Dev code review.

core-ai-bot commented 3 years ago

Comment by bchintx Friday Jan 03, 2014 at 22:41 GMT

Done with code review. Looks and works great! merging.