search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Reorder extension manager tabs #5328

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jasonsanjose Friday Nov 01, 2013 at 21:45 GMT Originally opened as https://github.com/adobe/brackets/pull/5817

Fix for #5512

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/5817/commits

core-ai-bot commented 3 years ago

Comment by njx Friday Nov 01, 2013 at 21:52 GMT

Wow, was it really that easy? MVC FTW

core-ai-bot commented 3 years ago

Comment by jasonsanjose Friday Nov 01, 2013 at 21:57 GMT

Yeah, I ran tests and scrubbed the extension manager code. The only improvements I could think of would be to extract the HTML templates for each tab and not rely on activeTabIndex.

core-ai-bot commented 3 years ago

Comment by njx Friday Nov 01, 2013 at 22:02 GMT

I was thinking there might be some timing issue, but looking at the code we're already asynchronously initializing both models at the same time anyway, so I guess it was already robust enough. Nice.

core-ai-bot commented 3 years ago

Comment by njx Friday Nov 01, 2013 at 22:03 GMT

Looks good to me. Merging.