[CLOSED] added Romanian locale

[core-ai-bot]

Issue by micnic Sunday Nov 03, 2013 at 22:36 GMT Originally opened as https://github.com/adobe/brackets/pull/5836

---

Romanian locale

---

micnic included the following code: https://github.com/adobe/brackets/pull/5836/commits

[core-ai-bot]

Comment by MarcelGerber Sunday Nov 03, 2013 at 22:51 GMT

---

Do you know anybody here on github who could review this?

[core-ai-bot]

Comment by micnic Sunday Nov 03, 2013 at 23:00 GMT

---

Unfortunately, I don't know anybody with authority who could review my Romanian translation, I am a native speaker of Romanian, and want to use Brackets in my native language.

[core-ai-bot]

Comment by jbalsas Sunday Nov 03, 2013 at 23:20 GMT

---

Hey@micnic, we don't need anyone with authority, just some other native speaker that could go through your translation, review it and let us know. If you don't know about anyone, probably@couzteau will ask in the dev list to see if someone pops up.

Additionally, we'll need you to sign the CLA before we can accept your contributions. You can do that at http://dev.brackets.io/brackets-contributor-license-agreement.html

[core-ai-bot]

Comment by micnic Monday Nov 04, 2013 at 07:55 GMT

---

Signed, I will try to find some more native speakers today, hope will find a lot of them.

[core-ai-bot]

Comment by sandulungu Monday Nov 04, 2013 at 08:36 GMT

---

Hello, I reviewed the strings and they look good.

[core-ai-bot]

Comment by cojocaru Monday Nov 04, 2013 at 08:45 GMT

---

Hi, great work, translations are fine.

[core-ai-bot]

Comment by bumbu Monday Nov 04, 2013 at 09:08 GMT

---

Checked. I have some minor remarks (I added few comments to commit) but overall it looks really good.

[core-ai-bot]

Comment by micnic Monday Nov 04, 2013 at 09:12 GMT

---

@bumbu Ceea ce tine de remarci, m-am condus in general de localizarea franceza, ma mai uit si mai modific daca trebuie, iar de niciunul vs nici un vezi aici: http://dexonline.ro/articol/Niciun_sau_nici_un%3F

[core-ai-bot]

Comment by micnic Monday Nov 04, 2013 at 09:47 GMT

---

Added some improvements after@bumbu 's remarks.

[core-ai-bot]

Comment by unNene Monday Nov 04, 2013 at 16:16 GMT

---

Eu as pune o virgulă după Live Preview:

"LIVE_DEVELOPMENT_ERROR_MESSAGE" : "Pentru a lansa Live Preview, Google Chrome trebuie să fie relansat cu opțiunea de depanarea la distanță activată.

Doriți ca Google Chrome să fie relansat cu opțiunea de depanare la distanță activată?",

În rest pare ok la o verificare vizuală.

I'm native speaker and I verified translations. Everything is ok.

[core-ai-bot]

Comment by micnic Tuesday Nov 05, 2013 at 08:39 GMT

---

@unNene , prima construcție trebuie să aibă un sens independent (să aibă un predicat) de ceea ce urmează după virgulă, dar aici e ceva de tipul: Pentru a cumpăra lapte trebuie să avem bani :D mai multe informații aici: http://www.scientia.ro/homo-humanus/44-dificultati-ale-limbii-romane/152-reguli-folosire-virgula.html

[core-ai-bot]

Comment by jbalsas Monday Nov 11, 2013 at 23:24 GMT

---

Hey@micnic, sorry this fell off my radar :S We're closing this sprint, so we'd like to land this if possible.

@bumbu@unNene Are we good to go with this?

[core-ai-bot]

Comment by bumbu Tuesday Nov 12, 2013 at 03:11 GMT

---

Yes, it is a good translation.

[core-ai-bot]

Comment by micnic Tuesday Nov 12, 2013 at 07:56 GMT

---

Hi@jbalsas, glad to hear this, I reviewed the files again and didn't find any typo or something wrong, we are good to go!

[core-ai-bot]

Comment by jbalsas Tuesday Nov 12, 2013 at 17:49 GMT

---

@bumbu Awesome!!

@micnic Thanks a lot for working on this! If you have time, a couple of extra strings landed in the last days https://github.com/adobe/brackets/commit/74dafa448dfe94a73e4d4ee28a4b23e8bef26b31 and the Serbian and Persian locale names. Feel free to submit a different PR for those.

@bumbu@unNene@romanroibu@cojocaru@sandulungu Thanks so much everyone for taking your time to review this!!

Merging