search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Code inspection improvements #5422

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by ingorichter Monday Nov 11, 2013 at 17:45 GMT Originally opened as https://github.com/adobe/brackets/pull/5935

Adding support (functional and partly visual) for having multiple code linters for the same document type. This means you can have both JSLint and JSHint (it's questionable if this makes sense) linter produce linting results.

Once a linter was registered for a file type, it will run with every save operation (unless this is disabled in the UI). There is no exposed UI way to enable/disable a linter, this means at the moment "All or nothing". You can uninstall the extension that provides the linter functionality to get rid of it's warnings. It's still TBD how a UI for this could look like.

Here is how ti looks like for a JSHint and JSLint fighting for your attention: screenshot 2013-11-11 09 42 27

ingorichter included the following code: https://github.com/adobe/brackets/pull/5935/commits

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Nov 13, 2013 at 23:51 GMT

@ingorichter Done reviewing. Thanks for adding all those unit tests! (Making up for me slacking off & leaving them out of the original CodeInspection PR :-P)

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Dec 03, 2013 at 10:06 GMT

@ingorichter Done with re-review of the main code. I didn't look at the unit tests yet, but I wanted to get you feedback on the rest sooner.

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Dec 09, 2013 at 03:42 GMT

@ingorichter Done rereviewing -- getting close!

Also looks like there's a merge conflict somewhere that needs to get resolved...

core-ai-bot commented 3 years ago

Comment by peterflynn Saturday Dec 14, 2013 at 04:25 GMT

@ingorichter You think you still have time to do those last fixes? Otherwise we may want to punt this to Sprint 36...

core-ai-bot commented 3 years ago

Comment by ingorichter Friday Dec 20, 2013 at 01:36 GMT

@peterflynn If you are not too tired of reviewing this... I hope, that I didn't miss anything this time

core-ai-bot commented 3 years ago

Comment by peterflynn Thursday Jan 09, 2014 at 03:46 GMT

@ingorichter I took the liberty of pushing up a commit that fixes the last few remaining comments I had (including the issue@busykai was hitting in #6375), along with a few more documentation updates.

So from my standpoint, I think it's good to land now. Do you want to take a look at my commit before merging?

core-ai-bot commented 3 years ago

Comment by peterflynn Thursday Jan 09, 2014 at 04:46 GMT

I've also filed bugs on the two extensions that will be broken by the inspectFile() API change, and documented the change in the release notes.

core-ai-bot commented 3 years ago

Comment by ingorichter Thursday Jan 09, 2014 at 19:06 GMT

@peterflynn Thank you for the last fixes. Tests passed. I think, we can go ahead and merge it. :+1:

core-ai-bot commented 3 years ago

Comment by peterflynn Thursday Jan 09, 2014 at 19:33 GMT

Oops, I realized the docs for inspectFile() said something incorrect (and had some mis-formatted type annotations) -- just pushed up a fix for that too. I think those docs-only fixes are noncontroversial enough that I can just go ahead & merge without further review.