search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [ImagePreview] img-header moving out of view #5447

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by MarcelGerber Tuesday Nov 12, 2013 at 21:07 GMT Originally opened as https://github.com/adobe/brackets/issues/5960

  1. Open a image that is too high to show it completely, so it has to be resized (in my case src/styles/images/propertiespanel_back@2x.png
  2. Decrease the height of the Brackets window

Result: The img-header content (resolution, path) moves up too far.

Expected: The img-header should be displayed correctly, the image itself should be resized.

Note: This also happens with pictures with more normal-shaped pictures (like Getting Started screenshot).

Screen: image

core-ai-bot commented 3 years ago

Comment by jasonsanjose Wednesday Nov 13, 2013 at 19:49 GMT

Low priority to@couzteau

core-ai-bot commented 3 years ago

Comment by couzteau Saturday Nov 16, 2013 at 00:39 GMT

Happens on window resize as well as on default view.

core-ai-bot commented 3 years ago

Comment by MarcelGerber Tuesday Jan 07, 2014 at 20:15 GMT

@couzteau Not fixed yet (just tested).

core-ai-bot commented 3 years ago

Comment by EJanuszewski Monday Jan 12, 2015 at 23:31 GMT

Anyone mind if I take a look at this?

core-ai-bot commented 3 years ago

Comment by redmunds Tuesday Jan 13, 2015 at 00:17 GMT

@EJanuszewski Nobody is working on it, so it's all yours. Thanks.

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Jan 13, 2015 at 00:45 GMT

@EJanuszewski Note that this may be tangled up in #10180 now, which is also related to vertical sizing.

core-ai-bot commented 3 years ago

Comment by EJanuszewski Tuesday Jan 13, 2015 at 12:49 GMT

@peterflynn Someone appears to have assigned themselves onto #10180 which appears to be related but not the same, so I'll still fix this one.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Tuesday Jan 13, 2015 at 15:26 GMT

@EJanuszewski Can you put up a Pull Request and tag both issues in the description then let@prksingh know that your solution may fix the issue he's looking at?

He picked that up because we tagged the issue with the 1.2 milestone but he may not have a solution yet,

core-ai-bot commented 3 years ago

Comment by EJanuszewski Tuesday Jan 13, 2015 at 15:54 GMT

@JeffryBooher Both should be in here https://github.com/adobe/brackets/pull/10364

core-ai-bot commented 3 years ago

Comment by prafulVaishnav Tuesday Feb 03, 2015 at 13:45 GMT

Pull request #10514 merged.. Thanks@EJanuszewski for the fix..