search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [Core][New Rule]: The New Rule dropdown is not closed when close the CSS inline editor or resize the window. #5482

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by julieyuan Friday Nov 15, 2013 at 06:57 GMT Originally opened as https://github.com/adobe/brackets/issues/6005

Steps:

  1. Launch Brackets and open the default sample project.
  2. New a css file, like : untitled-1.css.
  3. Open index.html file and put the cursor in a tag, like : <p>.
  4. Press Ctrl/Cmd + E to invoke CSS inline editor.
  5. Click the dropdown icon of New Rule.
  6. Close the inline editor by click x on the top left of the inline editor.
  7. After step5, resize Brackets window.

Result: At step6, the inline editor is closed, but the dropdown keeps open, if select one file from the dropdown, this css file can be opened in Working Set area. At step7, the dropdown keeps still and doesn't move.

Expected: At step6, the dropdown should be closed. At step7, it should move with the change of window.

ENV: MAC 10.7 and Win 8 English OS Build: 0.34.0-10711

Snapshots: Please refer to snapshots for reference: Step6: screen shot 2013-11-14 at 5 47 18 pm Step7: screen shot 2013-11-14 at 5 48 28 pm

core-ai-bot commented 3 years ago

Comment by redmunds Friday Nov 15, 2013 at 17:13 GMT

Assigning to me, Sprint 35, Medium Priority.

core-ai-bot commented 3 years ago

Comment by redmunds Wednesday Nov 20, 2013 at 17:24 GMT

I submitted a fix for these 2 cases.

Note that my fix for the resize editor case is different from the expectations of "At step7, it should move with the change of window." Instead, dropdown menu is dismissed. This is the same behavior as when scrolling editor.

core-ai-bot commented 3 years ago

Comment by njx Tuesday Dec 03, 2013 at 22:48 GMT

FBNC to@julieyuan

core-ai-bot commented 3 years ago

Comment by julieyuan Wednesday Dec 04, 2013 at 02:29 GMT

Thanks. Fix has not merged into latest build 0.35.0-10786 (master 4c6d88694) yet. I will verify it with next build.

core-ai-bot commented 3 years ago

Comment by julieyuan Thursday Dec 05, 2013 at 02:32 GMT

Verified this issue with build 0.35.0-10800. It is fixed. Thank you:-) Closing it. Here are snapshots for reference: After closing inline editor: screen shot 2013-12-04 at 6 27 45 pm After resizing inline editor: screen shot 2013-12-04 at 6 23 04 pm