brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Changing a rule identifier may get inline editor out of sync with the main (html) document #560

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by pthiess Thursday Apr 05, 2012 at 04:14 GMT Originally opened as https://github.com/adobe/brackets/issues/564


Changing a rule identifier such as a class name in the inline editor changes the content on disk but Inline editor stayed open although the (modified) class (name) is not part of the html file any longer.

1.) Reference a class "class1" defined uniquely in an external CSS file in the html code. 2.) Open the inline editor 3.) Change the class name to "class22" which is not defined elsewhere

Result: CSS file is updated correctly - shows now 'class22' as the identifier for the former 'class1' Inline editor does stay open although 'class22' is not referenced in the html code

Expected behavior (this might be a wrong assumption) : Inline editor should close since there is no relation between the shown rule and the main document any longer.

core-ai-bot commented 2 years ago

Comment by njx Thursday Apr 05, 2012 at 07:06 GMT


This is as designed--we felt that the user should be able to type anything they want in the inline editor without it closing, even if they somehow make the text inconsistent with the surrounding HTML code (otherwise it could close on you unexpectedly). However, we should consider showing some indication (like a warning icon) if it becomes inconsistent. Marking "to user story" for that enhancement and removing other labels.

core-ai-bot commented 2 years ago

Comment by njx Tuesday Apr 10, 2012 at 18:10 GMT


QRB reviewed

core-ai-bot commented 2 years ago

Comment by pthiess Friday Apr 13, 2012 at 01:49 GMT


Added to BS --> Story #306241