search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Request: Extension folder that doesn't clear when extension is updated #5809

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by Jacse Tuesday Jan 07, 2014 at 11:57 GMT Originally opened as https://github.com/adobe/brackets/issues/6389

I've developer the themes for brackets extension and tell my users to put their custom themes in a subdirectory of my extension.

The problem is whenever I update the extension all the users custom themes are removed.

Maybe there could be some special folder that doesn't update with the rest of the extension?

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Jan 07, 2014 at 21:16 GMT

@Jacse Probably a better approach is to have settings & configuration data stored outside the extension's install location. You could create a custom subdirectory under brackets.app.getApplicationSupportDirectory() for now (i.e. next to the "extensions" folder and the "cef_data" folder which contains user preferences, among other things).

We're currently migrating over to a user-editable JSON preferences format -- I'm not sure yet where we plan to store it, but maybe a subfolder of that location might be a good place to put configuration files like this? CC@dangoor in case he has any thoughts here.

core-ai-bot commented 3 years ago

Comment by Jacse Wednesday Jan 08, 2014 at 09:34 GMT

@peterflynn Yeah, sounds like a good plan with a folder for user preferences and possibly extension preferences.

core-ai-bot commented 3 years ago

Comment by dangoor Monday Jan 13, 2014 at 15:27 GMT

The new preferences just get stored in a .brackets.json file... it doesn't create a new directory for storing random other information.

The intention is definitely that extensions should be able to store their user preferences using the new built-in Brackets preferences manager. But, that doesn't extend to separate files as is needed in this case.

I agree with@peterflynn that a subdirectory in brackets.app.getApplicationSupportDirectory() seems like the right place for this. You might consider adding a menu item that opens the themes directory so that people can place them directly.

Ultimately, once we have extension dependencies and interaction between extensions, it seems like it would be best if individual themes were themselves extensions so that they can just be managed via the extension manager. Would that make sense@Jacse?

core-ai-bot commented 3 years ago

Comment by Jacse Monday Jan 13, 2014 at 16:08 GMT

Yes, themes as separate extensions would be the ultimate goal.

I'll look into using the specified folder, thanks.