search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Fix for deleting file from tree after rename from tree #5926

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jasonsanjose Tuesday Jan 14, 2014 at 19:42 GMT Originally opened as https://github.com/adobe/brackets/pull/6520

Fix for #6482.

@RaymondLim can you review?

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/6520/commits

core-ai-bot commented 3 years ago

Comment by RaymondLim Tuesday Jan 14, 2014 at 19:49 GMT

Reviewing...

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Jan 14, 2014 at 20:09 GMT

@RaymondLim looks like NPM is down, causing the travis failure. Feel free to just run grunt jshint locally on this branch before merging. Thanks!

core-ai-bot commented 3 years ago

Comment by RaymondLim Tuesday Jan 14, 2014 at 21:53 GMT

@jasonsanjose Done with initial review. Just one comment on JSDoc not matching with implementation.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Jan 14, 2014 at 22:12 GMT

@RaymondLim pushed a fix. Ready to go.