[CLOSED] Fix duplicate tree nodes when creating a file externally in a folder that was not loaded

[core-ai-bot]

Issue by jasonsanjose Thursday Jan 16, 2014 at 00:45 GMT Originally opened as https://github.com/adobe/brackets/pull/6546

---

• fix bug where unwatch was not called after file/folder was removed/renamed
• skip incremental update to jstree if directory was not loaded

---

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/6546/commits

[core-ai-bot]

Comment by peterflynn Thursday Jan 16, 2014 at 01:40 GMT

---

For #6537

[core-ai-bot]

Comment by peterflynn Thursday Jan 16, 2014 at 03:02 GMT

---

@jasonsanjose Done reviewing

[core-ai-bot]

Comment by jasonsanjose Thursday Jan 16, 2014 at 04:28 GMT

---

UGH. I think I just found a worse bug when debugging this one. If, external to brackets, I copy in a folder with a subfolder, then again externally try to rename the folder that I pasted, windows prevents me from doing so with this warning:

Folder In Use The action can't be completed because the folder or a file in it is open in another program. Close the folder or file and try again.

Note that this only happens for externally added folders that include a subfolder. Pasting in a folder with no subfolders doesn't no reproduce the issue. I assume that the file watcher for the subfolder is what is holding a file lock. I file separately since it's not quite related to this bug. That may be a blocker.

Filed #6551

[core-ai-bot]

Comment by jasonsanjose Thursday Jan 16, 2014 at 04:38 GMT

---

@peterflynn fix pushed. See above for issues not addressed.

[core-ai-bot]

Comment by jasonsanjose Thursday Jan 16, 2014 at 05:30 GMT

---

Closing in favor of #6553.