core-ai-bot
commented
3 years ago 
Also, menus and dialogs related to switching language should always be in English.
Open core-ai-bot opened 3 years ago
core-ai-bot
commented
3 years ago
Also, menus and dialogs related to switching language should always be in English.
core-ai-bot
commented
3 years ago 
This has something to do with #5503, just for reference
core-ai-bot
commented
3 years ago 
Reviewed. Low pri, starter bug.@busykai - agree with the original bug, but not sure we agree that the menu for switching language should always be in English - let's just fix the first part.
core-ai-bot
commented
3 years ago
@njx . Agree, as it was mentioned in #5503, it should be quite easy to remember position of the switch language menu by heart.
core-ai-bot
commented
3 years ago
It would maybe be a cool idea to provide the language names in both your currently selected and the original language.
Is it even possible for us to get such a value as Strings.root.OK?
core-ai-bot
commented
3 years ago 
I agree with@SAPlayer, that'd be nice (especially since this is more of a debugging workflow, so the person invoking it may not be a real speaker of the target language). If we can't get at the root Strings directly, we can always have two sets of strings -- the localized copies used today, plus an unlocalized set of "language self names."
core-ai-bot
commented
3 years ago
so instead of current/native language pairs why not use native/english instead? we can safely assume someone who's debugging is familiar with english. this way we don't have to localize them. we can just put the entire set of strings into root/strings-app.js. for any given combination of "native name"/"english name" is fixed (unless there's a revolution in that country, but then it becomes fixed again).
core-ai-bot
commented
3 years ago 
I thought that the Change Language feature was in the Debug menu since it wasn't a complete feature but it would be moved once it was. So I am thinking that eventually it might not be just for debugging.
core-ai-bot
commented
3 years ago 
I've started implementing this issue and just wanted to get clarification for what combination, if any, we want to use for displaying the languages. I've seen mention of Current/Self-name, Self-name/English, or just Self-name. (E.g. If in Spanish looking at German they would display "Alemán / Deutsch", "Deutsch / German", or "Deutsch", respectively)
core-ai-bot
commented
3 years ago
I just looked at some popular websites (Google, Adobe, Facebook, Mozilla, Wikipedia) - they all seem to use the third displaying.
core-ai-bot
commented
3 years ago
Fwiw, Mac OS uses only self and Windows is inconsistent -- the system language picker and keyboard layout pickers both use only current, while the display language installation list uses current+self (ref).
core-ai-bot
commented
3 years ago 
I think the third option given by@mjherna1 (that is self-name) should be good for the select language drop-down inside the pop-up. In addition to this, I think, in addition to this, we should keep the menu option as "@peterflynn Please decide on this so that I can start working on this.
core-ai-bot
commented
3 years ago
I've moved over the language self names to strings-app.js and everything is working great. However, not all languages have a self name from their particular locale file (Italian, Norwegian, Polish, Russian). Right now they'll default to their current language translation and if that doesn't exist it will fall back to English. It would be nice to finish the self name list eventually.
core-ai-bot
commented
3 years ago
@busykai This should now be fixed by #6725
core-ai-bot
commented
3 years ago 
In the switch language dialog, the languages should probably be listed using their own names. "English" for English, "Español" for Spanish and so on. The strings for these languages should be moved to strings-app.js . It's mostly important when switching from some language you may enable by an accident or for debugging purposes back to your own language.