search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Northstar syntax colors #613

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by gruehle Wednesday Apr 11, 2012 at 20:09 GMT Originally opened as https://github.com/adobe/brackets/pull/617

This is the first pass at adding the Northstar syntax colors.

The color values match the Northstar spec, but the token parsing used by CodeMirror is different than the token parsing used to generate the Northstar mockups, so there are some differences in applied colors.

gruehle included the following code: https://github.com/adobe/brackets/pull/617/commits

core-ai-bot commented 3 years ago

Comment by GarthDB Wednesday Apr 11, 2012 at 20:47 GMT

Can we put the theme in one file? So that it is easy to see and update. Also, is there a reason for naming the colors? Why not just use the hex? If we do want to name the colors it should be more semantic - more about the use of the color than the description of the color itself.

core-ai-bot commented 3 years ago

Comment by gruehle Wednesday Apr 11, 2012 at 21:12 GMT

I was just following the convention that@joelrbrandt used when the files were created.

The way the files are organized now we have: brackets_colors.less - This should be the only file that has any hex color values in it brackets_theme_default.less - This defines the semantic colors used, and values for the default theme brackets_codemirror_overrides.less - Map from CodeMirror theme to our semantic colors

I thought about collapsing the syntax colors into brackets_codemirror_overrides.less, but realized that other .less files use values defined in brackets_colors.less, and these should be consistent throughout the UI.

What do you recommend for managing colors? Ideally every hex value should only be entered once. With semantic colors it's common to end up with multiple color names having the same hex value.

core-ai-bot commented 3 years ago

Comment by GarthDB Wednesday Apr 11, 2012 at 21:18 GMT

I understand the benefit of changing the color in one place and it being updated, but if we decide to change the blue to a green, we have to find and replace for every place we used the original@blue. - might as well just use the raw hex value it is just as easy to find and replace it.

If all the name does is describe the color, I'm not sure it is any better than the hex which describes itself perfectly.

For the theme it might be best to use the names in Codemirror - I don't think we are tying any colors outside of the editor to the editor theme, so editing them would be fairly modular.

Garth Braithwaite Sent with Sparrow (http://www.sparrowmailapp.com)

On Wednesday, April 11, 2012 at 2:12 PM, Glenn Ruehle wrote:

I was just following the convention that@joelrbrandt used when the files were created.

The way the files are organized now we have: brackets_colors.less - This should be the only file that has any hex color values in it brackets_theme_default.less - This defines the semantic colors used, and values for the default theme brackets_codemirror_overrides.less - Map from CodeMirror theme to our semantic colors

I thought about collapsing the syntax colors into brackets_codemirror_overrides.less, but realized that other .less files use values defined in brackets_colors.less, and these should be consistent throughout the UI.

What do you recommend for managing colors? Ideally every hex value should only be entered once. With semantic colors it's common to end up with multiple color names having the same hex value.

Reply to this email directly or view it on GitHub: https://github.com/adobe/brackets/pull/617#issuecomment-5079116

core-ai-bot commented 3 years ago

Comment by gruehle Wednesday Apr 11, 2012 at 22:52 GMT

OK, how about this - I'll change the values for the semantic syntax colors to hex. This way all of the code coloring can be done in hex, and in a single file. This will also have the lowest impact on the rest of the colors in the app. Sound good?

core-ai-bot commented 3 years ago

Comment by GarthDB Wednesday Apr 11, 2012 at 23:00 GMT

sounds awesome.

Along this line I thought it would be interesting to have a sample swatch in css next to colors and make it toggleable.

Garth Braithwaite Sent with Sparrow (http://www.sparrowmailapp.com)

On Wednesday, April 11, 2012 at 3:52 PM, Glenn Ruehle wrote:

OK, how about this - I'll change the values for the semantic syntax colors to hex. This way all of the code coloring can be done in hex, and in a single file. This will also have the lowest impact on the rest of the colors in the app. Sound good?

Reply to this email directly or view it on GitHub: https://github.com/adobe/brackets/pull/617#issuecomment-5081013

core-ai-bot commented 3 years ago

Comment by gruehle Wednesday Apr 11, 2012 at 23:10 GMT

Changes pushed.