search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [cmv4] Fix code hint unit tests #6152

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by redmunds Thursday Feb 06, 2014 at 20:30 GMT Originally opened as https://github.com/adobe/brackets/pull/6779

This is for #6042 and unit tests for url hints and js parameter code hints.

Changes:

This fixes unit tests and I did some basic testing of code hints, but this has not been stress tested.

Note: use ?w=1 for Editor.js changes cc@njx

redmunds included the following code: https://github.com/adobe/brackets/pull/6779/commits

core-ai-bot commented 3 years ago

Comment by njx Thursday Feb 06, 2014 at 23:06 GMT

Did an initial review. My one general comment is that it seems like it would be better and more consistent to just have Editor._installEditorListeners() install the listeners for the CM events and then redispatch them as jQuery events, just like we do with the other CM events. That way you wouldn't have to depend on guessing that the active editor is the one that you got the event from.

core-ai-bot commented 3 years ago

Comment by redmunds Friday Feb 07, 2014 at 00:45 GMT

Oh, I didn't realize that CodeMirror also sent out those separate events -- that's much simpler. Closing.