core-ai-bot
commented
3 years ago Open core-ai-bot opened 3 years ago
core-ai-bot
commented
3 years ago core-ai-bot
commented
3 years ago 
@pthiess Is the same PR as the other one, but made from a branch instead of from master.I need to check if it has all the fixes I mentioned and then find someone to check the translation.
core-ai-bot
commented
3 years ago 
This https://github.com/adobe/brackets/pull/6851 seems to be the predecessor to this PR.
core-ai-bot
commented
3 years ago
@rogervila Would you mind signing the CLA http://dev.brackets.io/brackets-contributor-license-agreement.html? Otherwise we can't merge any contribution you've made so far. Thank you.
core-ai-bot
commented
3 years ago
@rogervila You still need to sign the Brackets contributor license agreement.
Also do you know someone who can review your translations? Just read them and post any required fixes or say that they all look good. Thanks
core-ai-bot
commented
3 years ago
@rogervila Any updates here? We are closing Release 37 and without you signing the contributor license agreement, this can't get merged for Release 37.
core-ai-bot
commented
3 years ago 
Hello! Sorry, I've been busy for few weeks The updates are here:
https://github.com/rogervila/brackets/commit/b776bd01e9b5d72ba860bdde279176f385917c7b
And I've signed the contributor license :)
Thank you very much!
core-ai-bot
commented
3 years ago
Done :) https://github.com/rogervila/brackets/commit/0029d48556a6cb7e7f0b780db12142b0b433b720
core-ai-bot
commented
3 years ago
Can you merge with master? There is a merge issue that you will have to fix, which is that we no longer need to add the language string to each language file and now we only add them to src/nls/root/strings-app.js.
Also do you know of someone that can check if the translations are ok or not, and post here any possible fixes? (I just know Spanish, so I can understand some things, but not all) If not, i'll post in the brackets forums.
core-ai-bot
commented
3 years ago
Hello@TomMalbran
I see that all language folders still having their own strings.js files
How can I add the translation on the src/nls/root/strings-app.js? Do you have an example?
If everything is correct after that I will commit the translation with the Master branch and I will make a new Pull Request
By the way, I don't know any Catalan person who has a GitHub account. It's a good idea to post it in the Brackets forum :)
core-ai-bot
commented
3 years ago
You need to merge with master. If your setup is like https://github.com/adobe/brackets/wiki/How-to-Hack-on-Brackets, you can do from your branch: git fetch upstream and then git merge upstream/master. If you fixed the strings that I mentioned before doing this, then you won't have any issues, if not, you might have some merge issues to fix.
After doing that, go to src/nls/root/strings-apps.js and add the LOCALE_CA string.
core-ai-bot
commented
3 years ago
@rogervila Hi. It's been a while since my last review and we haven't heard from you. We would like to know if you are still interested in this translation and if so if you can update it. Thanks!
core-ai-bot
commented
3 years ago 
Closing as this has gone stale. Thank you for the work along the way@rogervila and@TomMalbran
The Catalan translation for Brackets.
Si ets o parles català ajuda'm a traduir correctament Brackets al Català. El que interessa és que la traducció sigui fàcil de llegir, sense frases i paraules rebuscades, perquè l'ús de l'editor sigui accessible per a tothom.
Learn basic catalan language
Are you interested in this language? Start here! http://www.intercat.cat/speakcat/start.html :)
rogervila included the following code: https://github.com/adobe/brackets/pull/6893/commits