[CLOSED] Removes the Browse Extensions button in the default configuration.

[core-ai-bot]

Issue by dangoor Tuesday Feb 18, 2014 at 16:24 GMT Originally opened as https://github.com/adobe/brackets/pull/6908

---

This is a fix for #6800. If the extension_wiki_url configuration option is not set, the Browse Extensions button will not be displayed. In the default Brackets configuration, this value is no longer set.

---

dangoor included the following code: https://github.com/adobe/brackets/pull/6908/commits

[core-ai-bot]

Comment by pthiess Tuesday Feb 18, 2014 at 18:16 GMT

---

@lkcampbell Could you please take a look at this bug fix?

[core-ai-bot]

Comment by peterflynn Tuesday Feb 18, 2014 at 18:20 GMT

---

One minor thought: while we're in there, should we change the name of the property so it doesn't say "wiki"? Maybe extension_listing_url?

[core-ai-bot]

Comment by lkcampbell Tuesday Feb 18, 2014 at 20:29 GMT

---

I agree with@peterflynn. Any of these variable names that have "wiki" in them could be changed to the more generic "listing" format. We don't know if we will be using a wiki in the future, so might as well change them now.

[core-ai-bot]

Comment by lkcampbell Tuesday Feb 18, 2014 at 20:35 GMT

---

@dangoor, initial review complete. I tested this with the extension_wiki_url config properties set to "" and also to "https://github.com/adobe/brackets/wiki/Brackets-Extensions". The button appeared and disappeared as expected. All unit tests passed with the empty string setting and one unit test failed should not display the Browse Extensions button in the default configuration when I changed the default configuration. In other words, expected behavior.

[core-ai-bot]

Comment by dangoor Tuesday Feb 18, 2014 at 20:55 GMT

---

Thanks for the speedy review@lkcampbell and for the renaming suggestion@peterflynn. Review comments addressed.

[core-ai-bot]

Comment by lkcampbell Tuesday Feb 18, 2014 at 21:32 GMT

---

Looks good. Merging.