[CLOSED] [cmv4] Preserve multiple selections when saving new document or doing save as

core-ai-bot commented 3 years ago

Issue by njx Thursday Mar 06, 2014 at 02:43 GMT Originally opened as https://github.com/adobe/brackets/pull/7104

Noticed this bug randomly.@redmunds - trivial fix.

njx included the following code: https://github.com/adobe/brackets/pull/7104/commits

core-ai-bot commented 3 years ago

Comment by njx Thursday Mar 06, 2014 at 02:50 GMT

BTW, I did a scrub through the code base for all calls to getSelection() and getCursorPos(). Other than this one and another case in Quick Open which I have a separate bugfix for (for #6965), all other calls to these APIs should be correct given the current state of the world:

inline editors only deal with the primary selection
some functions like find use the current cursor position to start searches
code hints only use the primary cursor

So, overall, I think we've got all the places in the code that need to handle multiple selections, aside from this one.

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Mar 06, 2014 at 20:56 GMT

Merging.

brackets-archive / bracketsIssues

[CLOSED] [cmv4] Preserve multiple selections when saving new document or doing save as #6430