[CLOSED] Do not close/reopen live preview on currentDocumentChange

core-ai-bot commented 3 years ago

Issue by jasonsanjose Friday Mar 07, 2014 at 04:28 GMT Originally opened as https://github.com/adobe/brackets/pull/7119

This PR merges to randy/live-dev-fixes for #6889. This is not for master.

Optimization of live preview to the connected inspector and loaded agents instead of closing and reopening the browser
Use Page.navigate() instead and update agent and server state as needed.
Clean up agents to reset state if necessary on frameNavigated
Add original message data to Inspector protocol error logging to map errors to the originating message (if it exists)
Update "live development" strings to "live preview"

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/7119/commits

core-ai-bot commented 3 years ago

Comment by jasonsanjose Friday Mar 07, 2014 at 04:32 GMT

@redmunds this is a much more optimized way to switch HTML files while live preview is open. It's something I've wanted to fix for a while since the first big refactoring, but never got around to it. I believe it fixes all the issues I was seeing in #6889 even after your latest changes.

core-ai-bot commented 3 years ago

Comment by redmunds Friday Mar 07, 2014 at 17:41 GMT

Holy crap! It changes docs so fast I thought something was broken :) Awesome!

core-ai-bot commented 3 years ago

Comment by jasonsanjose Friday Mar 07, 2014 at 17:45 GMT

RIGHT?!

core-ai-bot commented 3 years ago

Comment by redmunds Friday Mar 07, 2014 at 19:53 GMT

Done with review.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Friday Mar 07, 2014 at 21:17 GMT

@redmunds ready

core-ai-bot commented 3 years ago

Comment by redmunds Friday Mar 07, 2014 at 21:31 GMT

Merging.

brackets-archive / bracketsIssues

[CLOSED] Do not close/reopen live preview on currentDocumentChange #6443