core-ai-bot
commented
3 years ago 
This does seem odd. On first launch there's no brackets.json file either, and we happily create a blank one without showing any warnings.
I think the error dialog is intended for the case where the file is present, but its syntax is invalid. In that case we really do want to show something in-your-face -- since the choices are to overwrite the file (losing the user's old prefs), or silently run with non-persisted prefs (losing the user's new pref changes), and both of those are pretty bad without explanation or a chance to intervene.
Deleting your prefs file causes a world of hurt:
~/config/Brackets/brackets.jsonYou are warned that the config file is missing.
You are warned that "brackets failed to read config file and it will be opened on startup"
At some point I had an empty prefs file and could toggle spaces to tabs and it wouldn't update the empty file with the preferences change but I cannot seem to reproduce that at the moment.
IMHO we should just silently create the file with the default settings if it is missing. There's no need to tell the user and/or open the file for their review in that case.
The Failed to Read prefs warning is alarming to the user -- we just use the default settings in that case anyway, you just can't save changes. I would prefer some other affordance and skip the whole preferences corrupt warning on startup. Since we just use the defaults in that case, it may be worth while displaying any corrupt message until the user tries to change a preference. I'm not sure how difficult it is to make that distinction, though.
Brackets' edge is to get into the editor quickly and have less in your way. This dialog violates both of thoese treaties. Perhaps
@larz0 can come up with an affordance for things this like a status bar indicator that the user can deal with when they get bored or lonely.