search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Define English (UK) language to use for differences between US and UK #6617

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by zaggino Wednesday Mar 26, 2014 at 19:16 GMT Originally opened as https://github.com/adobe/brackets/pull/7333

I need to use different date formats for US & UK and this'd enable me to do so.

Discussed also here: https://groups.google.com/forum/#!topic/brackets-dev/aeilzKeMeCw

P.S.: I'm not sure if the current language should be renamed into English (US)

ping@SAPlayer

zaggino included the following code: https://github.com/adobe/brackets/pull/7333/commits

core-ai-bot commented 2 years ago

Comment by ingorichter Thursday Mar 27, 2014 at 21:24 GMT

@zaggino I'm done with my review. Once we resolved the CLA check issue, I'm going to merge this PR. Thanks.

core-ai-bot commented 2 years ago

Comment by peterflynn Thursday Mar 27, 2014 at 21:45 GMT

@ingorichter I think we can merge even though the Travis build is failing... since we know@zaggino specifically has already signed it.

core-ai-bot commented 2 years ago

Comment by ingorichter Tuesday Apr 01, 2014 at 23:32 GMT

Thanks@zaggino! Merged!

core-ai-bot commented 2 years ago

Comment by hpoom Tuesday Apr 15, 2014 at 21:43 GMT

In strings.js it should be en-gb not en-UK. Also the default en needs changing to en-us.

See here http://en.m.wikipedia.org/wiki/Locale

core-ai-bot commented 2 years ago

Comment by RaymondLim Thursday Apr 17, 2014 at 20:43 GMT

@hpoom Your link does not show a list of all the country code, This will show the two-letter country codes .

@zaggino Can you submit a new pull request to correct this?