search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Project title text styles don't match Northstar #671

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Wednesday Apr 18, 2012 at 00:38 GMT Originally opened as https://github.com/adobe/brackets/issues/676

Issue 1: The font-weights in the folder tree still seem wrong...

In Northstar, folders and selected files are semibold weight; and other files are normal weight.

In Brackets master, folders and selected files are normal weight; and other files are light weight.

(The same holds true for the working set list also).

Issue 2: Compare in Brackets vs. Northstar the place in the project panel where your project's folder name is shown.

In Northstar the text is 14px #929292 (the same size as folder tree text but slightly darker).

In Brackets master the text is 13px #BBBBBB (smaller than the folder tree text but the same color as it).

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Apr 18, 2012 at 01:10 GMT

Broadening to reflect other text glitches in the same part of the UI (rather than filing multiple bugs).

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Apr 18, 2012 at 01:11 GMT

I'm going based off of the mockup (http://xd.corp.adobe.com/brackets/) rather than the PSD btw, so apologies if there was a conflict between the two and that explains the discrepancies here.

core-ai-bot commented 3 years ago

Comment by gruehle Wednesday Apr 18, 2012 at 18:30 GMT

For Issue 1, I tried using the same font weights as the Northstar prototype, but the text was much heavier than the prototype. Using light/normal was a better visual match with the prototype.

Issue 2 is a problem and will be fixed.

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Apr 18, 2012 at 18:49 GMT

Crud, I think we're looking at a Mac/Win discrepancy, then... On Windows, Brackets looks much closer to the mockup if I change the weights accordingly. The weights look noticeably too light as-is.

We could wait until the official TrueType outlines are available and see if that helps, but it sounded like that might not happen for a while. Is it worth just doing platform-conditional CSS for these weights so it looks right on Win right away?

core-ai-bot commented 3 years ago

Comment by gruehle Wednesday Apr 18, 2012 at 19:55 GMT

Ugh. I think it may be best to have hefty fonts on the mac until we get the final Source Sans fonts. I'm not sure why the fonts on the brackets prototype look so much different.

core-ai-bot commented 3 years ago

Comment by gruehle Friday Apr 20, 2012 at 17:29 GMT

Changing to FBNC and assigning to@peterflynn for closing.

core-ai-bot commented 3 years ago

Comment by peterflynn Saturday Apr 21, 2012 at 00:23 GMT

Looks good. Closing.

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Sep 04, 2012 at 23:07 GMT

Interestingly, the font weight discrepancy mentioned here (and described as a CEF1-specific issue in pull #694) is not fixed in CEF3-based brackets-shell...