[CLOSED] Inline Editor (Quick Edit) does not come up. Sprint 38

core-ai-bot commented 3 years ago

Issue by MiguelCastillo Saturday Apr 26, 2014 at 15:10 GMT Originally opened as https://github.com/adobe/brackets/issues/7660

So, maybe I am missing something. But I have tried getting inline editors to come up based on the description here. https://github.com/adobe/brackets/wiki/How-to-Use-Brackets

I have tried sprint 38 vanilla with no extensions... I have also tried running from git:master.

I haven't had any luck getting inline editors to come up. So, I expect inline editor to come up if I place the cursor in update in script below below in line scrollbarsApply.update(themeManager);.


    function scrollbarsApply(themeManager) {
        scrollbarsApply.update(themeManager);
    }

    scrollbarsApply.update = function(themeManager) {
        theme = themeManager ? themeManager.getThemes()[0] : (theme || {});
        if ( Settings.getValue("customScrollbars") ) {
            var scrollbar = (theme.scrollbar || []).join(" ");
            $scrollbars.text(scrollbar || "");
        }
        else {
            $scrollbars.text("");
        }
    };

    scrollbarsApply.enable = function(themeManager) {
        Settings.setValue("customScrollbars", true);
        scrollbarsApply.update(themeManager);
    };

    scrollbarsApply.disable = function(themeManager) {
        Settings.setValue("customScrollbars", true);
        scrollbarsApply.update(themeManager);
    };

core-ai-bot commented 3 years ago

Comment by tomByrer Monday Apr 28, 2014 at 15:06 GMT

I've noticed this also while editing HTML & hoping to open the Quick Edit CSS: bug-brackets0 38 0-12606_quickeditbroke I'm rather certain that col-sm-3 is in bootstrap.min.css.

core-ai-bot commented 3 years ago

Comment by lkcampbell Monday Apr 28, 2014 at 15:19 GMT

@MiguelCastillo, I tried out the scenario you described above and it is working correctly for me on Brackets 38, Mac OS Mavericks. Also works correctly on my latest dev build of 39.

What is happening when you try to bring the Quick Edit? Nothing? Or are you getting the red twipsy that says that the quick edit can't be opened?

core-ai-bot commented 3 years ago

Comment by lkcampbell Monday Apr 28, 2014 at 15:27 GMT

@tomByrer, it might be failing because the file is minified. I'm not even sure that Quick Editing a minified file would be useful for you anyway. Can you get a regular version of the file and use that for your development instead?

core-ai-bot commented 3 years ago

Comment by tomByrer Monday Apr 28, 2014 at 19:18 GMT

it might be failing because the file is minified

Urm CSS minification only takes out whitespace, so you're telling me Bracket's CSS parser depends on whitespace?!? But since you requested, I used the unminified version, & still no rules.

Does Brackets use a CSS parser like mensch?

core-ai-bot commented 3 years ago

Comment by lkcampbell Monday Apr 28, 2014 at 19:33 GMT

@tomByrer, I don't know for sure, would have to dig into the code. I'm just doing some quick troubleshooting to rule in or rule out the source of the problem. I will play with it a bit and see if I can repro the problem as well.

core-ai-bot commented 3 years ago

Comment by tomByrer Monday Apr 28, 2014 at 19:45 GMT

More testing:

The .HTM I'm editing has loads 6 stylesheets. Thinking that might be a cause, I deleted all references except css/form-entry.css. Save As.. new file.
Closed Brackets, re-opened my new HTM.
I Quick Edit a div.
Brackets told me correctly I don't have a rule for it, so I [New Rule].
New Rule opens main.css which I did have in my previous .HTM but I deleted that <link>! I did a Find on main.css, & there were 0 references in my current HTM.
I Quick Edit a rule I had in main.css, & it found the correct rule (still no <link href="css/main.css"...> in my HTM remember)
I Quick Edit a rule for my currently linked css/form-entry.css, & Brackets could not find it.

I hope this narrows down the problem?

core-ai-bot commented 3 years ago

Comment by lkcampbell Monday Apr 28, 2014 at 19:46 GMT

@tomByrer, you are correct, the minified file does pop up in the Quick Edit. It's not pretty, but it does work.

However, I am not reproducing your problem. Let me look through the info you just posted and see if I can find anything.

core-ai-bot commented 3 years ago

Comment by tomByrer Monday Apr 28, 2014 at 19:54 GMT

Thanks for your persistent research!
After more testing, it seems only rules in my main.css can be found via Quick Edit, but not my other CSS files.

core-ai-bot commented 3 years ago

Comment by TomMalbran Monday Apr 28, 2014 at 19:55 GMT

Brackets looks for the CSS files that are in the folder currently open in the project tree/sidebar. It doesn't look if the files are actually linked or looks for files that are not in the current folder, even if the files are open.

core-ai-bot commented 3 years ago

Comment by lkcampbell Monday Apr 28, 2014 at 19:55 GMT

@tomByrer, it doesn't look like you need to have a link in your HTML to have the CSS pop up in your list of possible CSS. I created a project with only two files: test.html and test.css. No links in the HTML file. test.css still shows up. I believe it just goes through the project. Is bootstrap in your current project?

core-ai-bot commented 3 years ago

Comment by tomByrer Monday Apr 28, 2014 at 20:09 GMT

Brackets looks for the CSS files that are in the folder currently open in the project tree/sidebar

I don't have any folders open in the Project Tree; I didn't know this was needed. Either way, how is Brackets finding css/main.css? But that does 'fix' the issue at hand sort of...; I can now Quick Edit the first reference Brackets finds. But that means there are other bugs:

Brackets looks at main.css if the folder is not open in Project Tree, which may be unlinked.
Brackets erroneously looks at ALL files in Project Tree linked or not; many times a CSS file will only be used by certain sub-pages.
Only the first reference is opened for editing, when there may be many other references that can/should be opened.
If you aren't using a CSS file that is in a sub-folder of the current Project Tree, you can't Quick Edit it.
Brackets ignores <link>s.
Perhaps I missed it in the docs, but the Quick Edit-New Rule warning should advise to ensure having Project tree open.

Should all these have separate issues opened? Thanks for all you help guys!

core-ai-bot commented 3 years ago

Comment by lkcampbell Monday Apr 28, 2014 at 20:23 GMT

@tomByrer, Yes, it would probably be a good idea to get your suggestions posted. The "only show CSS files that are linked to the current HTML" is an intriguing idea. Don't know if it has been considered before or not.

I would do a good search of existing issues before you file them. There may be some good history available on these problems as well.

At the very least, we should stop hijacking@MiguelCastillo's bug ;). Get some of these discussions put in there own postings.

core-ai-bot commented 3 years ago

Comment by lkcampbell Monday Apr 28, 2014 at 20:26 GMT

@MiguelCastillo, sorry for the temporary departure. To get back to the original bug, my last question to you is:

What is happening when you try to bring the Quick Edit? Nothing? Or are you getting the red twipsy that says that the quick edit can't be opened?

core-ai-bot commented 3 years ago

Comment by tomByrer Monday Apr 28, 2014 at 20:28 GMT

we should stop hijacking MiguelCastillo's bug ;).

I was thinking they were related; he might not have the file in his Project Tree either :)

core-ai-bot commented 3 years ago

Comment by TomMalbran Monday Apr 28, 2014 at 20:39 GMT

Actually "only show CSS files that are linked to the current HTML" will break lots of workflows:

Many times the linked files are not even relative paths, but complete urls. I do this when I use PHP and a .htaccess to make pretty urls.
In several projects I just use templates so that most of the html files are small files that combined make the whole file. Brackets won't be able to know which styles go to each document by using linked files.
You could easily change the linked styles in JavaScript, usually by adding new ones. So Brackets will not know about that.

Responding to the other questions/suggestions:

Notice that when there are several files with the searched selector, those appear on the right side and you can click them to switch between all th files.
We will soon have filters for Quick Edit, so that we can select on which files to not search.
If you are working on a project, open the folder that contains all the files, then Brackets will have access to all the files. It doesn't just look inside the selected folder, it looks inside all the files in the project tree.

Notice that in Brackets there is always an open project, so maybe there was a main.css file in the folder you were working on, even if it actually was from another project, or you where in a sub-folder inside your project.

core-ai-bot commented 3 years ago

Comment by lkcampbell Monday Apr 28, 2014 at 20:41 GMT

@tomByrer, his issue involves only a single file. Quick editing a function contained in the same file. Also a Quick Edit issue but a different kind of issue.

@MiguelCastillo, also, are you getting any dev tools console errors when you try to use Quick Edit?

core-ai-bot commented 3 years ago

Comment by MiguelCastillo Monday Apr 28, 2014 at 20:41 GMT

Weird, it is coming up now! I am not sure what happened... But, good news is that just showed that themes is applying to inline editors. I need to do some thorough testing of this. @lkcampbell I know you have some feedback on this... Any particular use case you think I should look into?

core-ai-bot commented 3 years ago

Comment by lkcampbell Monday Apr 28, 2014 at 21:00 GMT

@MiguelCastillo, the main issue is: https://github.com/MiguelCastillo/Brackets-Themes/issues/63.

I confirmed that it is a problem on Mac OS as well; however, on Windows it is a much more serious issue. With Mac, the inline editor simply opens once more then shuts. On Windows, according to the bug report, it never shuts.

If you are able to see the inline editor now, we should probably close this issue, since you can now work on https://github.com/MiguelCastillo/Brackets-Themes/issues/63.

core-ai-bot commented 3 years ago

Comment by MiguelCastillo Monday Apr 28, 2014 at 21:14 GMT

YIKES! I have been soo busy I have put that in the back burner. I will try to fix that Wednesday, which is when I have some "free" cycles... :/

@lkcampbell if you found a solution, you would become the new WWW sensation :D

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Apr 28, 2014 at 21:18 GMT

Just to clarify the officially expected behavior here:

Brackets searches all CSS files in your "project," regardless of what <link> tags are in the HTML file. If you'd like to see this change, please upvote https://trello.com/c/SdihjjmS/645-css-quick-edit-improved-heuristics-filtering (or send us a PR!)
"Project" is defined as whatever folder is at the root of the file tree you see at left -- i.e. the folder you selected via File > Open Folder. It does not matter which folders are visually expanded/collapsed in the tree view -- all .css files in the whole tree are searched.
The CSS search only looks at the rightmost simple selector (so e.g. in .a .b > span.c only the span.c part is loooked at)
What is searched for depends on where your cursor is:
- If your cursor is on a tag name, only selectors with that tag name appear in the results. Ids or class names on the tag or in the selector are all ignored.
- If your cursor is on a class attribute, only selectors with that class name appear in the results. Id and tag name are ignored.
- If the class attribute lists multiple classes, only one is searched for. If your cursor isn't directly on a single value, it's not well defined which one Brackets will search for (see bug #7389), so always put your cursor directly on the class name.
- If your cursor is on an id attribute, only selectors with that class name appear in the results. Class names and the tag's name are ignored.
Whitespace in the CSS file should not make any difference -- any CSS file that shows correct syntax highlighting when you open it should work fine.

@MiguelCastillo@tomByrer If you're seeing cases that don't match these rules, please make a small, simple project that illustrates the problem, post the entire project as a Gist, and then post a link to it here so we can investigate.

core-ai-bot commented 3 years ago

Comment by lkcampbell Monday Apr 28, 2014 at 21:39 GMT

@tomByrer, see, you didn't even have to do any research, the history came right to you :). As@peterflynn said, if you still have any issues after reviewing the information provided, you can file them per his criteria above.

@MiguelCastillo, if I have some time, I will look into the Quick Edit themes problem, although I don't have access to a Windows machine so I can't confirm any fix I create for Windows. Regardless, I am closing this issue since the original problem no longer exists for@MiguelCastillo.

brackets-archive / bracketsIssues

[CLOSED] Inline Editor (Quick Edit) does not come up. Sprint 38 #6889