brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Keyboard shortcut overlap with Chrome #6893

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by awakekat Sunday Apr 27, 2014 at 19:44 GMT Originally opened as https://github.com/adobe/brackets/issues/7667


I am using the most current version of both Chrome and Brackets on a Mac. I am using Live View with Chrome. Some changes were not updating in Chrome so I hit the keyboard combination for Chrome to force a reload Command-Shift-R. Unfortunately Brackets window was active sending what looked like a reset to the application. I found that Command-Shift-R is the keyboard combo for Reloading without Extensions. Not Cool. Any way to reassign Brackets Reloading without Extensions to something else possibly?

core-ai-bot commented 2 years ago

Comment by njx Monday Apr 28, 2014 at 21:00 GMT


Hi@awakekat - unfortunately we don't yet have a way to configure keyboard shortcuts. This is definitely something we want to add relatively soon, and it's on our backlog: https://trello.com/c/3mZwu1DE.

However, it's a little worrisome that you weren't seeing changes update. Were you editing a static HTML file, a server-based file like PHP, or something else? We have another open bug (#6600) that we should autoreload on save for any "non-live" files (which would take care of PHP and other server files), and in theory we should already be doing this for JS. But for static HTML files, live updating should always work.

I also think it would make sense to just have a keyboard shortcut to force-reload the live page in case everything else isn't working (basically the functionality you were trying to use). It looks like there's an extension that does this called "Reload in Browser", but it's pretty old and the shortcut it tries to register is (surprise!) Cmd-Shift-R, so that shortcut won't work in current versions of Brackets anyway. We should consider just adding this functionality to core Brackets (but will still have the shortcut issue until we make them configurable).

Leaving open till next bug review to figure out what we want to do here.

core-ai-bot commented 2 years ago

Comment by njx Monday May 05, 2014 at 18:53 GMT


Reviewed. We discussed going ahead and implementing "Force Reload in Browser" and actually mapping it to Cmd-Shift-R - since the thing that's currently mapped to Cmd-Shift-R (reload without extensions) isn't something that should be commonly used anyway; we could pick a different shortcut for it.

This should be pretty easy to implement: should just do the same thing that LiveDevelopment._onDocumentSaved() does at the end (call reconnect() and Inspector.Page.reload()). Marking starter bug, low priority.

core-ai-bot commented 2 years ago

Comment by tacryt-socryp Sunday Jun 08, 2014 at 16:33 GMT


@njx I would like to get started on this.

core-ai-bot commented 2 years ago

Comment by tacryt-socryp Sunday Jun 08, 2014 at 18:30 GMT


@njx@awakekat I just submitted a pull request that would fix this. https://github.com/adobe/brackets/pull/8076

core-ai-bot commented 2 years ago

Comment by maltemuth Sunday Jun 08, 2014 at 21:26 GMT


sorry for the duplicate PR, I didn't notice your comment when I started to work on this as well

core-ai-bot commented 2 years ago

Comment by dangoor Wednesday Jun 25, 2014 at 20:11 GMT


This has been fixed on master. Thanks for@maltemuth and@loganallenc for contributing patches for this!