search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Implementation of Northstar menu appearance #696

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by njx Friday Apr 20, 2012 at 01:40 GMT Originally opened as https://github.com/adobe/brackets/pull/701

@peterflynn

njx included the following code: https://github.com/adobe/brackets/pull/701/commits

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Apr 20, 2012 at 19:33 GMT

Done reviewing. Just that one comment.

core-ai-bot commented 3 years ago

Comment by njx Friday Apr 20, 2012 at 19:56 GMT

Factored out the highlight color. I also added the fix for #673 (which involved moving the ::before rules back inside the "a" rule).

core-ai-bot commented 3 years ago

Comment by njx Friday Apr 20, 2012 at 22:19 GMT

@peterflynn I removed that rule. Should be good to merge now.

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Apr 20, 2012 at 22:45 GMT

Excellent, merged now